Skip to content

Conversation

@pavan-sh
Copy link
Contributor

@pavan-sh pavan-sh commented Feb 5, 2026

🎯 Changes

This updates two test cases to use the more common spelling “dependent” instead of “dependant”:

  • Angular experimental injectQuery tests
  • Vue useQuery tests

No runtime behavior changes—test-only rename + matching queryKey strings for consistency.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Tests
    • Corrected naming consistency across test suites to improve code quality and maintainability.

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2026

⚠️ No Changeset found

Latest commit: dda6e3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

Two test files across different packages have spelling corrections applied, changing "dependant" to "dependent" in test descriptions, query keys, and assertion checks. No functional behavior changes.

Changes

Cohort / File(s) Summary
Test Typo Corrections
packages/angular-query-experimental/src/__tests__/inject-query.test.ts, packages/vue-query/src/__tests__/useQuery.test.ts
Corrected spelling from "dependant" to "dependent" in test names, query keys, and objectContaining assertions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

package: angular-query-experimental

Suggested reviewers

  • arnoud-dv
  • TkDodo

Poem

A typo hopped by, oh what a sight!
"Dependant" should be "Dependent"—now it's right!
The rabbit fixed spelling across the test ground,
One letter corrected, two files sound! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: renaming test cases from 'dependant' to 'dependent' for spelling consistency.
Description check ✅ Passed The description follows the template structure with all required sections completed: Changes section explains the update with motivation, Checklist is present with one item marked, and Release Impact section correctly identifies this as dev-only with no release impact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Feb 10, 2026

View your CI Pipeline Execution ↗ for commit dda6e3c

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 3m 4s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 27s View ↗

☁️ Nx Cloud last updated this comment at 2026-02-10 16:28:12 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 10, 2026

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@10096

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@10096

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@10096

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@10096

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@10096

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@10096

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@10096

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@10096

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@10096

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@10096

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@10096

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@10096

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@10096

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@10096

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@10096

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@10096

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@10096

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@10096

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@10096

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@10096

commit: dda6e3c

@TkDodo TkDodo merged commit 29cf1bd into TanStack:main Feb 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants