Skip to content

test(react-query/useQuery.promise): unskip 'cancelQueries' while suspending test by keeping 'queryFn' in-flight #10910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sukvvon wants to merge 4 commits into
base: main
Choose a base branch
from
+8 −6
Draft

test(react-query/useQuery.promise): unskip 'cancelQueries' while suspending test by keeping 'queryFn' in-flight #10910

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da463ca
test(react-query/useQuery.promise): unskip 'cancelQueries' while susp…
sukvvon Jun 10, 2026
053a7af
test(react-query/useQuery.promise): clarify why 'sleep' is extended i…
sukvvon Jun 10, 2026
6eea5cd
Merge branch 'main' into test/react-query-unskip-cancel-queries-while…
sukvvon Jun 11, 2026
9f788de
Merge branch 'main' into test/react-query-unskip-cancel-queries-while…
sukvvon Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions packages/react-query/src/__tests__/useQuery.promise.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,14 +788,16 @@ describe('useQuery().promise', { timeout: 10_000 }, () => {
expect(queryFn).toHaveBeenCalledOnce()
})

it.skip('should stay pending when canceled with cancelQueries while suspending until refetched', async () => {
it('should stay pending when canceled with cancelQueries while suspending until refetched', async () => {
const renderStream = createRenderStream({ snapshotDOM: true })
const key = queryKey()
let count = 0
const queryFn = vi.fn().mockImplementation(async () => {
await sleep(10)
return 'test' + count++
})
// `sleep` is longer than usual on purpose: with `shouldAdvanceTime`, the
// real time spent rendering and awaiting `takeRender` (~40ms) is added to
// the fake clock, so a shorter fetch would resolve before `cancel` can take
// effect. A longer fetch keeps the query in-flight when it is cancelled.
const queryFn = vi
.fn()
.mockImplementation(() => sleep(50).then(() => 'test'))

const options = {
queryKey: key,
Expand Down
Loading