Skip to content

chore(start): update Rsbuild to v2.0.0-rc.3 and remove workaround#7194

Open
chenjiahan wants to merge 1 commit intoTanStack:rsbfrom
chenjiahan:update_rsbuild_remove_workaround_0415
Open

chore(start): update Rsbuild to v2.0.0-rc.3 and remove workaround#7194
chenjiahan wants to merge 1 commit intoTanStack:rsbfrom
chenjiahan:update_rsbuild_remove_workaround_0415

Conversation

@chenjiahan
Copy link
Copy Markdown

  • Update @rsbuild/core and @rsbuild/plugin-react to 2.0.0-rc.3
  • Remove the chunkSplit.strategy workaround from e2e cases

Copilot AI review requested due to automatic review settings April 15, 2026 07:48
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bcdc67fd-cfa3-4804-9dbd-39dd680f80c5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s Rsbuild-based Start e2e fixtures and related packages to use Rsbuild v2.0.0-rc.3, and removes the previously-required chunkSplit.strategy workaround from e2e configs.

Changes:

  • Bump @rsbuild/core / @rsbuild/plugin-react usage in Rsbuild e2e projects to 2.0.0-rc.3.
  • Remove performance.chunkSplit.strategy workaround blocks from Rsbuild e2e configs.
  • Refresh lockfile and add @rsbuild/core devDependency in some Start packages for local development.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pnpm-lock.yaml Lockfile refresh for Rsbuild/Rspack updates and new/updated e2e importers (contains a problematic local link: entry).
packages/vue-start/package.json Adds @rsbuild/core devDependency and reorders deps/peers.
packages/solid-start/package.json Adds @rsbuild/core devDependency and reorders deps.
packages/react-start/package.json Reorders deps and adds @rsbuild/core devDependency (currently set to ^2.0.0-rc.2).
e2e/vue-start/basic-rsbuild/rsbuild.config.ts Removes chunkSplit.strategy workaround.
e2e/vue-start/basic-rsbuild/package.json Updates @rsbuild/core to 2.0.0-rc.3.
e2e/solid-start/basic-rsbuild/rsbuild.config.ts Removes chunkSplit.strategy workaround.
e2e/solid-start/basic-rsbuild/package.json Updates @rsbuild/core to 2.0.0-rc.3.
e2e/react-start/rsc-rsbuild/rsbuild.config.ts Removes chunkSplit.strategy workaround comment/config.
e2e/react-start/rsc-rsbuild/package.json Updates @rsbuild/core and @rsbuild/plugin-react to 2.0.0-rc.3.
e2e/react-start/basic-rsbuild/rsbuild.config.ts Removes chunkSplit.strategy workaround comment/config.
e2e/react-start/basic-rsbuild/package.json Updates @rsbuild/core and @rsbuild/plugin-react to 2.0.0-rc.3.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pnpm-lock.yaml
Comment thread pnpm-lock.yaml
Comment thread packages/react-start/package.json
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 01f6cfa554

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pnpm-lock.yaml
@chenjiahan chenjiahan force-pushed the update_rsbuild_remove_workaround_0415 branch from 01f6cfa to b94c2ba Compare April 15, 2026 07:55
@github-actions
Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 0166fe8ba0f3
  • Measured at: 2026-04-15T07:58:00.459Z
  • Baseline source: history:f7f00250f39c
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Raw Brotli Trend
react-router.minimal 87.57 KiB +226 B (+0.25%) 275.82 KiB 76.10 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-router.full 90.84 KiB +214 B (+0.23%) 287.12 KiB 79.00 KiB ▂▁▁▁▁▁▁▁▁▂▂█
solid-router.minimal 35.60 KiB +95 B (+0.26%) 107.36 KiB 31.94 KiB ▃▁▁▁▁▁▁▁▁▁▁█
solid-router.full 40.07 KiB +89 B (+0.22%) 120.90 KiB 35.96 KiB ▂▁▁▁▁▁▁▂▂▂▂█
vue-router.minimal 53.46 KiB +165 B (+0.30%) 153.16 KiB 48.00 KiB ▂▁▁▁▁▁▁▁▁▁▁█
vue-router.full 58.36 KiB +163 B (+0.27%) 168.62 KiB 52.25 KiB ▂▁▁▁▁▁▁▁▁▁▁█
react-start.minimal 101.96 KiB +198 B (+0.19%) 323.81 KiB 88.14 KiB ▁▁▁▁▁▁▁▁▁▂▂█
react-start.full 105.39 KiB +183 B (+0.17%) 334.16 KiB 91.16 KiB ▂▁▁▁▁▁▁▁▁▂▂█
solid-start.minimal 49.62 KiB +106 B (+0.21%) 153.24 KiB 43.76 KiB ▃▁▁▁▁▁▁▂▂▂▂█
solid-start.full 55.15 KiB +119 B (+0.21%) 169.48 KiB 48.46 KiB ▂▁▁▁▁▁▁▁▁▁▁█

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants