chore(start): update Rsbuild to v2.0.0-rc.3 and remove workaround#7194
chore(start): update Rsbuild to v2.0.0-rc.3 and remove workaround#7194chenjiahan wants to merge 1 commit intoTanStack:rsbfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the repo’s Rsbuild-based Start e2e fixtures and related packages to use Rsbuild v2.0.0-rc.3, and removes the previously-required chunkSplit.strategy workaround from e2e configs.
Changes:
- Bump
@rsbuild/core/@rsbuild/plugin-reactusage in Rsbuild e2e projects to2.0.0-rc.3. - Remove
performance.chunkSplit.strategyworkaround blocks from Rsbuild e2e configs. - Refresh lockfile and add
@rsbuild/coredevDependency in some Start packages for local development.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile refresh for Rsbuild/Rspack updates and new/updated e2e importers (contains a problematic local link: entry). |
| packages/vue-start/package.json | Adds @rsbuild/core devDependency and reorders deps/peers. |
| packages/solid-start/package.json | Adds @rsbuild/core devDependency and reorders deps. |
| packages/react-start/package.json | Reorders deps and adds @rsbuild/core devDependency (currently set to ^2.0.0-rc.2). |
| e2e/vue-start/basic-rsbuild/rsbuild.config.ts | Removes chunkSplit.strategy workaround. |
| e2e/vue-start/basic-rsbuild/package.json | Updates @rsbuild/core to 2.0.0-rc.3. |
| e2e/solid-start/basic-rsbuild/rsbuild.config.ts | Removes chunkSplit.strategy workaround. |
| e2e/solid-start/basic-rsbuild/package.json | Updates @rsbuild/core to 2.0.0-rc.3. |
| e2e/react-start/rsc-rsbuild/rsbuild.config.ts | Removes chunkSplit.strategy workaround comment/config. |
| e2e/react-start/rsc-rsbuild/package.json | Updates @rsbuild/core and @rsbuild/plugin-react to 2.0.0-rc.3. |
| e2e/react-start/basic-rsbuild/rsbuild.config.ts | Removes chunkSplit.strategy workaround comment/config. |
| e2e/react-start/basic-rsbuild/package.json | Updates @rsbuild/core and @rsbuild/plugin-react to 2.0.0-rc.3. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01f6cfa554
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
01f6cfa to
b94c2ba
Compare
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
@rsbuild/coreand@rsbuild/plugin-reactto2.0.0-rc.3chunkSplit.strategyworkaround from e2e cases