perf(virtual-core): skip sync DOM reads during normal scrolling#1144
Merged
piecyk merged 1 commit intoTanStack:mainfrom Mar 12, 2026
Merged
perf(virtual-core): skip sync DOM reads during normal scrolling#1144piecyk merged 1 commit intoTanStack:mainfrom
piecyk merged 1 commit intoTanStack:mainfrom
Conversation
|
|
View your CI Pipeline Execution ↗ for commit a1f20f5
☁️ Nx Cloud last updated this comment at |
piecyk
force-pushed
the
perf/skip-sync-measure
branch
from
dedc5bb to
10db36b
Compare
piecyk
force-pushed
the
perf/skip-sync-measure
branch
from
10db36b to
a1f20f5
Compare
4 tasks
piecyk
added a commit
that referenced
this pull request
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Inline _measureElement into measureElement and RO callback to simplify the measurement flow. During normal user scrolling, the ref callback (measureElement) now only registers the element with the ResizeObserver, the actual measurement is deferred to the async RO callback, avoiding layout thrashing from forced reflows.
Sync measurement in measureElement is gated behind scrollState, so it only runs during programmatic scrolling (scrollToIndex/scrollToOffset) where reconcileScroll needs sizes in the same frame to converge correctly.
✅ Checklist
pnpm run test:pr.🚀 Release Impact