Closed
Conversation
Removed comment about building the player list.
…hen someone sends a message.
Author
|
lowkey bad😭😭😭 |
TechStudent10
requested changes
Apr 3, 2026
Owner
TechStudent10
left a comment
TechStudent10
left a comment
There was a problem hiding this comment.
As cool as the tags feature is, I don't exactly want it the way it's being implemented here. Huge props for it, don't get me wrong, but I'd wanted implemented differently and would rather do it myself.
I'd honestly separate the bugfix for LobbyLayer::refresh into its own PR, and that would probably be something that I'd merge. I'd also appreciate if the comments were in English
Author
|
Okay the close? |
Author
|
I just messing around with code and suggests |
Author
|
I close pull req |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crash on lobby recreation & Add player profile viewing
This PR fixes a crash that happens when you leave a lobby and try to create a new one. The issue was caused by asynchronous callbacks executing on the main thread and trying to access a destroyed LobbyLayer (dangling pointer). To fix this, I added a std::shared_ptr m_alive lifecycle flag to safely check if the layer exists before running the callbacks. I also made sure to properly unbind all events in unregisterListeners.
Additionally, I added a small feature: clicking on a player's nickname in the lobby will now open their Geometry Dash profile page,tags for lobby, notifications when someone leaves or joins, and when someone sends a message..