Closed
Conversation
Contributor
|
@Julian-TMD I believe you were still on an old version of the main branch, I already added these devices in #5. Feel free to double-check! |
Author
|
@Jeehut |
Contributor
|
Thanks for catching these missing iPads - you were spot on about iPad15,3 and iPad15,7! I went ahead and added them along with the cellular variants (iPad15,4, 15,5, 15,6, 15,8) since they were announced at the same time. Also did a bit of cleanup:
Your feedback was super helpful for the audit! I've credited you in commit 10aff84. Closing this PR since the changes are already in #8 with the additional devices. Let me know if you spot anything else! 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.