Main marcxml21#2154
Open
smutniak wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
fixes issue #2123 pending further info |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the MARC21 XML export to emit 650 subject fields from dc.subject values (instead of using the submission’s major), aligning subject output with existing subject handling in other exporters.
Changes:
- Replace MARC 650 generation from single
MAJORvalue to iteratingSUBJECT_FIELD_VALUES(dc.subject). - Add
SUBJECT_FIELD_VALUESintoMarcXML21Keyand populate it inMarcXML21Formatter. - Adjust MARC template comments around 650/653 to reflect the new mapping.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/resources/formats/marc21_xml.xml | Generate MARC 650 fields from SUBJECT_FIELD_VALUES instead of MAJOR; tweak related comments. |
| src/main/java/org/tdl/vireo/model/formatter/MarcXML21Formatter.java | Populate Thymeleaf context with SUBJECT_FIELD_VALUES via SubmissionHelperUtility.getSubjectFieldValues(). |
| src/main/java/org/tdl/vireo/model/export/enums/MarcXML21Key.java | Add new enum key SUBJECT_FIELD_VALUES for the MARC21 formatter/template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
11
to
15
| DEPOSIT_URL, | ||
| ABSTRACT, | ||
| SUBJECT_FIELD_VALUES, | ||
| KEYWORD_FIELD_VALUES, | ||
| DEPARTMENT, |
Comment on lines
+221
to
+223
| <datafield th:each="subject: ${SUBJECT_FIELD_VALUES}" tag="650" ind1=" " ind2=" "> | ||
| <subfield th:text="${ subject.getValue() }" code="a"></subfield> | ||
| </datafield> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses dc.subject instead of major for subject values tag 650