fixed order in submission and admin view#2155
Open
cstarcher wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes unstable ordering of “Custom Actions” displayed in the submission/admin list view by sorting action values by their definition’s configured position, and by exposing that position in the JSON view used for submission lists.
Changes:
- Sort
row.customActionValuesin the admin list UI bydefinition.positionto keep display order stable across select/deselect updates. - Expose
CustomActionDefinition.positioninViews.SubmissionListJSON via an overriddengetPosition()with@JsonView.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/webapp/app/views/admin/list.html | Orders rendered custom action values by definition.position to prevent UI reordering. |
| src/main/java/org/tdl/vireo/model/CustomActionDefinition.java | Makes position available in the SubmissionList JSON view so the UI can reliably sort by it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/TexasDigitalLibrary/Vireo/sessions/f0a08f30-1f9f-400b-ad8d-b923231196a5 Co-authored-by: cstarcher <5767401+cstarcher@users.noreply.github.com>
…exasDigitalLibrary/Vireo into 2104_submission_custom_actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents reordering of custom actions in submission and admin views when actions are selecte/deselected
Resolves #2104
Type of Change
AI Usage Disclosure
AI Tool(s) Used Including Version:
GPT-5.3-Codex
Nature of Use:
Additional Description: