Open
Conversation
Aearsears
force-pushed
the
fix-md-links-event-bug
branch
from
1fc8654 to
2b00b7b
Compare
Aearsears
force-pushed
the
fix-md-links-event-bug
branch
from
d3d9485 to
9ccc785
Compare
willmcgugan
requested changes
Sep 28, 2025
Member
willmcgugan
left a comment
willmcgugan
left a comment
There was a problem hiding this comment.
Can we have tests to cover more code paths?
Suggest you implement an open_url in app to check if the expected urls where called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #6039
Hi all first time contributor around here. I had a look into this bug where clicking on a MD link would cause FileNotFoundError. What seemed to be happening is that
MarkdownViewerand its childMarkdownboth handled theMarkdown.LinkClickedmessage. I thought the order of messages isnt guaranteed but the childMarkdownwould get the message first?To fix this, if its a HTTP link I let
Markdownhandle it and stop propagation to parent. If its an anchor or a file,MarkdownViewerhandles it. please let me know your reviewPlease review the following checklist.