Fix some uses of using namespace#9528
Fix some uses of using namespace#9528maliberty merged 15 commits intoThe-OpenROAD-Project:masterfrom
using namespace#9528Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the broad using namespace sta; with specific using declarations in RepairDesign.cc and RepairHold.cc. This is a good practice to avoid namespace pollution and potential symbol conflicts. However, some symbols that were previously available via the sta namespace (either directly or through nested using declarations in OpenSTA headers) are now missing, which will lead to compilation errors. Specifically, sta::Slacks and std::sort need to be explicitly imported or qualified where they are used unqualified.
|
clang-tidy review says "All clean, LGTM! 👍" |
hzeller
force-pushed
the
feature-20260223-no-use-ns
branch
2 times, most recently
from
bb05061 to
cd6c3f9
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
hzeller
force-pushed
the
feature-20260223-no-use-ns
branch
from
cd6c3f9 to
692a6a7
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
What's the motivation? I understood the motivation to get rid of |
|
I see #9525, let's discuss there |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
``` src/rmp/src/Restructure.cpp: #include "sta/GraphClass.hh" for sta::VertexSet src/rsz/src/ConcreteSwapArithModules.cc: #include "sta/GraphClass.hh" for sta::VertexSet src/rsz/src/RecoverPower.hh: #include "sta/GraphClass.hh" for sta::VertexSet ``` Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260223-no-use-ns
branch
from
692a6a7 to
00f5b41
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
|
I am doing this manually, so I first need to break out the using clauses before I can fix the inline implementation. Maybe there is a tool for that, but first steps first. I can keep working on this until we have the inline situation, but I need to break this into several commits to stay sane :) |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Alright, done. |
|
clang-tidy review says "All clean, LGTM! 👍" |
src/rsz/src/RepairSetup.cc
Outdated
| using sta::Delay; | ||
| using sta::Edge; | ||
| using sta::fuzzyEqual; | ||
| using sta::fuzzyGreater; | ||
| using sta::fuzzyGreaterEqual; | ||
| using sta::fuzzyLess; | ||
| using sta::InstancePinIterator; | ||
| using sta::Path; | ||
| using sta::PathExpanded; | ||
| using sta::Scene; | ||
| using sta::Slack; | ||
| using sta::TimingArc; | ||
| using sta::Vertex; | ||
| using sta::VertexInEdgeIterator; | ||
| using sta::VertexOutEdgeIterator; | ||
| using sta::VertexSet; |
|
Thanks for doing this manual work. I hope it will be acceptable to all. |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
The CI error seems to be some docker glitch |
maliberty
merged commit 9e689fc
into
The-OpenROAD-Project:master
3 participants
No description provided.