Skip to content

Use @rules_python directly, don't rename.#9558

Closed
hzeller wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
hzeller:feature-20260226-no-py-rename
Closed

Use @rules_python directly, don't rename.#9558
hzeller wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
hzeller:feature-20260226-no-py-rename

Conversation

@hzeller
Copy link
Collaborator

@hzeller hzeller commented Feb 26, 2026

Not sure why there was a renamed version, but I suspect it was due toe some conflicting import from some former WORKSPACE dependency.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the rules_python Bazel dependency from version 1.2.0 to 1.8.5 and removes the repository renaming from @openroad_rules_python to the standard @rules_python. This simplifies the build configuration. All usages across the various BUILD.bazel files have been updated accordingly, and the MODULE.bazel.lock file has been regenerated to reflect these dependency changes. The changes are correct and improve the project's dependency management.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@hzeller hzeller force-pushed the feature-20260226-no-py-rename branch from c8aedfb to 9fccdcc Compare February 26, 2026 19:01
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty enabled auto-merge February 26, 2026 19:56
@hzeller
Copy link
Collaborator Author

hzeller commented Feb 26, 2026

is there something going on with docker ?

@maliberty
Copy link
Member

I don't see any docker issue, just

[2026-02-26T19:56:39.499Z] ModuleNotFoundError: No module named 'yaml'

@hzeller
Copy link
Collaborator Author

hzeller commented Feb 27, 2026

Oh, it is something in the orfs part that I can not be run properly locally as it uses docker.

There is no import yaml anywhere in the OpenROAD repository, so I suspect this might be some missing dependency in imported scripts there ? @oharboe do you have an idea ?

@oharboe
Copy link
Collaborator

oharboe commented Feb 27, 2026

Oh, it is something in the orfs part that I can not be run properly locally as it uses docker.

There is no import yaml anywhere in the OpenROAD repository, so I suspect this might be some missing dependency in imported scripts there ? @oharboe do you have an idea ?

repository rules run with local python that don't have yaml installed?

@oharboe
Copy link
Collaborator

oharboe commented Feb 27, 2026

@hzeller
Copy link
Collaborator Author

hzeller commented Feb 27, 2026 via email

Not sure why there was a renamed version, but I suspect it
was due toe some conflicting import from some former
`WORKSPACE` dependency.

Signed-off-by: Henner Zeller <h.zeller@acm.org>
auto-merge was automatically disabled March 2, 2026 08:58

Head branch was pushed to by a user without write access

@hzeller hzeller force-pushed the feature-20260226-no-py-rename branch from 9fccdcc to 03c7d27 Compare March 2, 2026 08:58
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

clang-tidy review says "All clean, LGTM! 👍"

@hzeller
Copy link
Collaborator Author

hzeller commented Mar 2, 2026

I've rebased to head with #9579 included, but it still seems to have a yaml problem

https://jenkins.openroad.tools/job/OpenROAD-Public/job/PR-9558-merge/6/stages/?start-byte=5467&selected-node=496#log-496-13

CC @oharboe to have a look.

12:22:28  (12:22:28) ERROR: /tmp/workspace/OpenROAD-Public_PR-9558-merge-6-bazel-ci/test/orfs/ram_8x7/BUILD:10:10: Action test/orfs/ram_8x7/results/asap7/ram_8x7/base/1_2_yosys.v failed: (Exit 2): bash failed: error executing Action command (from target //test/orfs/ram_8x7:ram_8x7_synth) /bin/bash -c ... (remaining 7 arguments skipped)
12:22:28  
12:22:28  Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
12:22:28  Traceback (most recent call last):
12:22:28    File "/home/user/.cache/bazel/_bazel_user/cba90eb80939bb9aee16c7845a6a90b7/sandbox/processwrapper-sandbox/12815/execroot/_main/external/bazel-orfs++orfs_repositories+docker_orfs/OpenROAD-flow-scripts/flow/scripts/defaults.py", line 4, in <module>
12:22:28      import yaml
12:22:28  ModuleNotFoundError: No module named 'yaml'
12:22:28  Traceback (most recent call last):
12:22:28    File "/home/user/.cache/bazel/_bazel_user/cba90eb80939bb9aee16c7845a6a90b7/sandbox/processwrapper-sandbox/12815/execroot/_main/bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/bazel-orfs+/pythonwrapper/python3.runfiles/bazel-orfs+/pythonwrapper/_python3_stage2_bootstrap.py", line 499, in <module>

@oharboe
Copy link
Collaborator

oharboe commented Mar 2, 2026

yes, this is the next problem. Will have a look

@hzeller
Copy link
Collaborator Author

hzeller commented Mar 3, 2026

I discombobulated my local branch; continuing this PR in #9603

@hzeller hzeller closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants