Use @rules_python directly, don't rename.#9558
Use @rules_python directly, don't rename.#9558hzeller wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
@rules_python directly, don't rename.#9558Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the rules_python Bazel dependency from version 1.2.0 to 1.8.5 and removes the repository renaming from @openroad_rules_python to the standard @rules_python. This simplifies the build configuration. All usages across the various BUILD.bazel files have been updated accordingly, and the MODULE.bazel.lock file has been regenerated to reflect these dependency changes. The changes are correct and improve the project's dependency management.
|
clang-tidy review says "All clean, LGTM! 👍" |
c8aedfb to
9fccdcc
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
is there something going on with docker ? |
|
I don't see any docker issue, just |
|
Oh, it is something in the orfs part that I can not be run properly locally as it uses docker. There is no |
repository rules run with local python that don't have yaml installed? |
|
On Fri, Feb 27, 2026, 08:12 Øyvind Harboe ***@***.***> wrote:
*oharboe* left a comment (The-OpenROAD-Project/OpenROAD#9558)
<#9558 (comment)>
@hzeller <https://github.com/hzeller> How about
The-OpenROAD-Project/OpenROAD-flow-scripts#3932
<The-OpenROAD-Project/OpenROAD-flow-scripts#3932>
?
Using the batteries that are included by default sounds good!
—
… Reply to this email directly, view it on GitHub
<#9558 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABCNCJ7VNY4Q4XCLSABBUL4N7U4HAVCNFSM6AAAAACWA45BY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNZRGIZTONBVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Not sure why there was a renamed version, but I suspect it was due toe some conflicting import from some former `WORKSPACE` dependency. Signed-off-by: Henner Zeller <h.zeller@acm.org>
Head branch was pushed to by a user without write access
9fccdcc to
03c7d27
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I've rebased to head with #9579 included, but it still seems to have a yaml problem CC @oharboe to have a look. |
|
yes, this is the next problem. Will have a look |
|
I discombobulated my local branch; continuing this PR in #9603 |
Not sure why there was a renamed version, but I suspect it was due toe some conflicting import from some former
WORKSPACEdependency.