rsz: skip floating nets during makeBufferedNetGroute#9567
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request correctly identifies and skips floating nets during buffered net construction, which is a valuable improvement. However, there is a critical issue regarding a potential null pointer dereference. The db_net variable is dereferenced to call getTermCount() before being checked for null, which could lead to a crash if findFlatDbNet returns nullptr. Additionally, the assert(db_net != nullptr); is misplaced and would not prevent this issue in release builds. A null check for db_net should be performed immediately after its assignment.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
4 participants
No description provided.