Skip to content

pad: stop looping over fillers when gap is complete#9583

Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
gadfort:pad-fix-filler
Mar 2, 2026
Merged

pad: stop looping over fillers when gap is complete#9583
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
gadfort:pad-fix-filler

Conversation

@gadfort
Copy link
Collaborator

@gadfort gadfort commented Mar 1, 2026

Changes:

  • Dont continue through the filler loop once gap is filled, otherwise the cells marked as overlap permitted will get added even when they are not needed.
  • Correct the test to actually cause overlaps and check for them

Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
@gadfort gadfort requested a review from maliberty March 1, 2026 15:51
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue in the filler placement logic where it would continue to add fillers even after a gap was completely filled, especially when permit_overlaps is used. The change in ICeWall.cpp stops the iteration over different filler types once the gap is filled, which is a good improvement. The test case in skywater130_overlapping_filler.tcl has been updated to correctly trigger and test this scenario.

I've found a minor remaining issue in the logic where a single extra filler can still be placed in some conditions. My review comment provides details and a suggestion for a more complete fix.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

clang-tidy review says "All clean, LGTM! 👍"

@maliberty maliberty merged commit f23e8b2 into The-OpenROAD-Project:master Mar 2, 2026
13 checks passed
@gadfort gadfort deleted the pad-fix-filler branch March 2, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants