pad: stop looping over fillers when gap is complete#9583
Merged
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom Mar 2, 2026
Merged
pad: stop looping over fillers when gap is complete#9583maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
maliberty merged 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue in the filler placement logic where it would continue to add fillers even after a gap was completely filled, especially when permit_overlaps is used. The change in ICeWall.cpp stops the iteration over different filler types once the gap is filled, which is a good improvement. The test case in skywater130_overlapping_filler.tcl has been updated to correctly trigger and test this scenario.
I've found a minor remaining issue in the logic where a single extra filler can still be placed in some conditions. My review comment provides details and a suggestion for a more complete fix.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: