odb: Use snake_case for LEF58 cut rules parser variables (#2275)

[Divinesoumyadip]

Description

This PR continues the refactoring effort for issue #2275. It updates the Boost.Spirit qi::rule variable names from SCREAMING_SNAKE_CASE to standard snake_case in several LEF58 parser files. This ensures compliance with the Google C++ Style Guide and improves internal consistency within the odb module.

Files Modified

src/odb/src/lefin/ArraySpacingParser.cpp
src/odb/src/lefin/KeepOutZoneParser.cpp
src/odb/src/lefin/lefTechLayerCutEnclosureParser.cpp
src/odb/src/lefin/lefTechLayerCutSpacingParser.cpp
src/odb/src/lefin/lefTechLayerCutSpacingTableParser.cpp

Testing

Successful local build using make. And passed all OpenDB integration tests via ctest -R odb .

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[gemini-code-assist]

Code Review

This pull request successfully refactors the Boost.Spirit parser rule variables to use snake_case, improving consistency with the Google C++ Style Guide. However, the automatic reformatting for long lines has introduced some unconventional and inconsistent code styles. My review includes specific suggestions to improve the formatting for better readability and maintainability.

[gemini-code-assist]

This line break before the assignment operator is unconventional and harms readability. It's better to keep the declaration and assignment on one line. If the line is too long, it should be broken after an operator like &&, which is the pattern used in other files in this PR.

  bool valid = qi::phrase_parse(first, last, enclosure_rule, space) && first == last;

[gemini-code-assist]

This formatting is unconventional. A more standard way to break long declaration lines is to place the = on the same line as the variable name and indent the following lines.

Suggested change

	qi::rule<std::string::const_iterator, space_type>
	parallel_within_cut_class_rule
	= (lit("CUTCLASS")
	qi::rule<std::string::const_iterator, space_type>
	parallel_within_cut_class_rule =
	(lit("CUTCLASS")

[gemini-code-assist]

This formatting is unconventional. A more standard way to break long declaration lines is to place the = on the same line as the variable name and indent the following lines.

Suggested change

	qi::rule<std::string::const_iterator, space_type>
	non_opposite_enclosure_spacing_rule
	= (lit("NONOPPOSITEENCLOSURESPACING")
	qi::rule<std::string::const_iterator, space_type>
	non_opposite_enclosure_spacing_rule =
	(lit("NONOPPOSITEENCLOSURESPACING")

[gemini-code-assist]

This formatting is unconventional. A more standard way to break long declaration lines is to place the = on the same line as the variable name and indent the following lines.

Suggested change

	qi::rule<std::string::const_iterator, space_type>
	OPPOSITEENCLOSURERESIZESPACING
	opposite_enclosure_resize_spacing_rule
	= (lit("OPPOSITEENCLOSURERESIZESPACING")
	qi::rule<std::string::const_iterator, space_type>
	opposite_enclosure_resize_spacing_rule =
	(lit("OPPOSITEENCLOSURERESIZESPACING")

[eder-matheus]

@Divinesoumyadip Notice that you added the same changes in this PR that you already applied here: #9721.

This can conflict if we merge #9721 first, so please be sure to not mix things up in different PRs.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"

[eder-matheus]

@Divinesoumyadip please look at the conflicts with master.

[Divinesoumyadip]

@Divinesoumyadip please look at the conflicts with master.

Thanks, @eder-matheus ,I'm resolving the conflicts with master now and will push the update shortly

[Divinesoumyadip]

Conflicts resolved! I synced with master and ensured the changes from PR #9721 for ArraySpacingParser.cpp and KeepOutZoneParser.cpp are preserved. The remaining cut spacing parser files are ready for review

@Divinesoumyadip please look at the conflicts with master.

Conflicts resolved! I synced with master and ensured the changes from PR #9721 for ArraySpacingParser.cpp and KeepOutZoneParser.cpp are preserved. The remaining cut spacing parser files are ready for review.

[github-actions]

clang-tidy review says "All clean, LGTM! 👍"