Skip to content

Add GUI README fixes + more informative docs debug msg#9735

Merged
maliberty merged 3 commits intoThe-OpenROAD-Project:masterfrom
luarss:topic/add-docs-debug
Mar 12, 2026
Merged

Add GUI README fixes + more informative docs debug msg#9735
maliberty merged 3 commits intoThe-OpenROAD-Project:masterfrom
luarss:topic/add-docs-debug

Conversation

@luarss
Copy link
Contributor

@luarss luarss commented Mar 12, 2026

Addresses feedback in #9683

@oharboe @maliberty FYI

Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@luarss luarss requested a review from maliberty March 12, 2026 02:25
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the debug message for the documentation generation script, making it easier to find formatting errors in README files. It also adds new documentation for a GUI feature.

My review includes a fix for a bug in the new debug logic that could fail with duplicate headers, and a minor formatting suggestion for the new documentation to ensure consistent heading levels.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
@luarss
Copy link
Contributor Author

luarss commented Mar 12, 2026

Also fixed a bug with image render on readthedocs.

image

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@oharboe
Copy link
Collaborator

oharboe commented Mar 12, 2026

I'm skeptical of complexity and feature rich CI.

My main priority would be to have simple fast local tests that require no maintainence in .yaml scripts or Jenkins.

#9733

@hzeller FYI

@oharboe oharboe self-requested a review March 12, 2026 06:45
Copy link
Collaborator

@oharboe oharboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am skeptical of having an edit, test, debug cycle that involves CI. This flow should be entirely local and fast.

Ideally, CI is just a go-no go catchall if something wasn't caught locally and it should provide an easy to spot command to reproduce the problem locally for fast local edit, test, debug cycles.

@luarss
Copy link
Contributor Author

luarss commented Mar 12, 2026

@oharboe This is complementary to your PR. It just adds more informative messages to the same base md_roff_compat.py script for debugging. I am also in favor of the local dev flow

@maliberty maliberty merged commit decea19 into The-OpenROAD-Project:master Mar 12, 2026
15 checks passed
@luarss luarss deleted the topic/add-docs-debug branch March 12, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants