Add GUI README fixes + more informative docs debug msg#9735
Add GUI README fixes + more informative docs debug msg#9735maliberty merged 3 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request improves the debug message for the documentation generation script, making it easier to find formatting errors in README files. It also adds new documentation for a GUI feature.
My review includes a fix for a bug in the new debug logic that could fail with duplicate headers, and a minor formatting suggestion for the new documentation to ensure consistent heading levels.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Jack Luar <39641663+luarss@users.noreply.github.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
I am skeptical of having an edit, test, debug cycle that involves CI. This flow should be entirely local and fast.
Ideally, CI is just a go-no go catchall if something wasn't caught locally and it should provide an easy to spot command to reproduce the problem locally for fast local edit, test, debug cycles.
|
@oharboe This is complementary to your PR. It just adds more informative messages to the same base |

Addresses feedback in #9683
@oharboe @maliberty FYI