Add tags = ["manual"] to all test/orfs targets#9741
Open
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Open
Add tags = ["manual"] to all test/orfs targets#9741oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
oharboe wants to merge 1 commit intoThe-OpenROAD-Project:masterfrom
Conversation
bazelisk build //... was building test/orfs artifacts that should only be built when explicitly running tests. Add manual tag to all 60 targets that were missing it (filegroups, sh_tests, orfs_flow test_kwargs) so that wildcard patterns skip them entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully implements the new tagging policy for test/orfs/ targets. By adding tags = ["manual"] to various filegroup, orfs_flow, and sh_test rules, and updating test_kwargs to include both manual and orfs tags, the change ensures that bazelisk build //... will no longer build ORFS test artifacts. The README.md has also been updated to clearly document this policy and provide verification steps. The changes are consistent and correctly applied across all modified files, achieving the stated objective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bazelisk build //... was building test/orfs artifacts that should only be built when explicitly running tests. Add manual tag to all 60 targets that were missing it (filegroups, sh_tests, orfs_flow test_kwargs) so that wildcard patterns skip them entirely.