Refactor character filtering for consistency in pangram check#14257
Closed
Tithi234 wants to merge 3 commits intoTheAlgorithms:masterfrom
Closed
Refactor character filtering for consistency in pangram check#14257Tithi234 wants to merge 3 commits intoTheAlgorithms:masterfrom
Tithi234 wants to merge 3 commits intoTheAlgorithms:masterfrom
Conversation
Refactored is_pangram function to use isalpha for letter check and removed benchmark function.
for more information, see https://pre-commit.ci
Added a benchmark function to compare performance of different is_pangram implementations.
Contributor
Author
|
Closing this PR to keep the repository clean as the current CI checks are failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
is_pangramstr.isalpha()for clarity and consistencyWhat type of change is this?
Checklist: