Skip to content

Refactor character filtering for consistency in pangram check#14257

Closed
Tithi234 wants to merge 3 commits intoTheAlgorithms:masterfrom
Tithi234:patch-18
Closed

Refactor character filtering for consistency in pangram check#14257
Tithi234 wants to merge 3 commits intoTheAlgorithms:masterfrom
Tithi234:patch-18

Conversation

@Tithi234
Copy link
Contributor

@Tithi234 Tithi234 commented Feb 7, 2026

Describe your change:

  • Simplifies character filtering logic in is_pangram
  • Uses str.isalpha() for clarity and consistency
  • Keeps behavior and doctests unchanged

What type of change is this?

  • Fix a bug or typo in an existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md
  • This pull request is all my own work
  • I know that pull requests will not be merged if they fail the automated tests
  • This PR only changes one algorithm file
  • All functions and variable names follow Python naming conventions
  • All function parameters and return values are annotated with Python type hints
  • All functions have doctests that pass the automated testing

Tithi234 and others added 2 commits February 7, 2026 08:37
Refactored is_pangram function to use isalpha for letter check and removed benchmark function.
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Feb 7, 2026
Added a benchmark function to compare performance of different is_pangram implementations.
@Tithi234
Copy link
Contributor Author

Tithi234 commented Feb 7, 2026

Closing this PR to keep the repository clean as the current CI checks are failing.
I’ll revisit this with a cleaner approach in the future.
Thanks to the maintainers for the review process.

@Tithi234 Tithi234 closed this Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant