Skip to content

fix: pin unpinned GitHub Actions to commit SHAs #14453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dagecko wants to merge 1 commit into from
+9 −7
Closed

fix: pin unpinned GitHub Actions to commit SHAs #14453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
steps:
- run: sudo apt-get update && sudo apt-get install -y libhdf5-dev
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@v7
- uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7
Copy link
Member

@cclauss cclauss Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is # v7, whereas the current version is v7.6.0, so if you are going to pin to the latest version, then comment needs to match.

v7 allows GitHub Actions to run the latest-and-greatest 7.x.y version trusting Astral's Semantic Versioning. If we are going to pin to a particular version, then Dependabot will generate a ton more pull requests.

with:
enable-cache: true
cache-dependency-glob: uv.lock
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/devcontainer_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: devcontainers/ci@v0.3
- uses: devcontainers/ci@8bf61b26e9c3a98f69cb6ce2f88d24ff59b785c6 # v0.3
Copy link
Member

@cclauss cclauss Mar 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is # v0.3, whereas the current version is v0.3.1900000417, so if you are going to pin to the latest version, then comment needs to match.

v0.3 allows GitHub Actions to run the latest-and-greatest 0.3.y version trusting devcontainers' Semantic Versioning. If we are going to pin to a particular version, then Dependabot will generate a ton more pull requests.

with:
push: never
runCmd: "true"
4 changes: 3 additions & 1 deletion .github/workflows/directory_writer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ jobs:
scripts/build_directory_md.py 2>&1 | tee DIRECTORY.md
git config --global user.name "$GITHUB_ACTOR"
git config --global user.email "$GITHUB_ACTOR@users.noreply.github.com"
git remote set-url origin https://x-access-token:${{ secrets.GITHUB_TOKEN }}@github.com/$GITHUB_REPOSITORY
git remote set-url origin https://x-access-token:${GITHUB_TOKEN}@github.com/$GITHUB_REPOSITORY
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

@cclauss cclauss Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does GitHub recommend this in their docs?

- name: Update DIRECTORY.md
run: |
git add DIRECTORY.md
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/project_euler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
libhdf5-dev
libopenblas-dev
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@v7
- uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7
- uses: actions/setup-python@v6
with:
python-version: 3.14
Expand All @@ -40,7 +40,7 @@ jobs:
libhdf5-dev
libopenblas-dev
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@v7
- uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7
- uses: actions/setup-python@v6
with:
python-version: 3.14
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ruff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@v7
- uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7
- run: uvx ruff check --output-format=github .
2 changes: 1 addition & 1 deletion .github/workflows/sphinx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
libhdf5-dev
libopenblas-dev
- uses: actions/checkout@v6
- uses: astral-sh/setup-uv@v7
- uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7
- uses: actions/setup-python@v6
with:
python-version: 3.14
Expand Down
Loading