RETAIL_COMPATIBLE_XFER_SAVE=0 crashes silently on savegame

[githubawn]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

game silently crashes, it could tell the user that the savegame can't be loaded

00000000.sav.debug (example savegame, remove .debug)

Reproduction Steps

1. save game on generalszh-weekly-2026-02-13.zip
2. compile game with #define RETAIL_COMPATIBLE_XFER_SAVE (0)
3. load save game
4. it silently crashes

Additional Context

No response

[xezon]

Do you have a callstack for this crash?

Is this report refering to #2418 ? It would be good to finalize that fix.

[githubawn]

No callstack available at the moment. I also haven't looked at 2418 yet, so I can't confirm whether this is related.

[Caball009]

generalszh.exe!std::vector<UpdateModule *,std::allocator<UpdateModule *>>::operator[](const unsigned int _Pos) Line 1888
generalszh.exe!GameLogic::eraseSleepyUpdate(int i) Line 2802
generalszh.exe!GameLogic::processDestroyList() Line 2540
generalszh.exe!GameLogic::destroyAllObjectsImmediate() Line 300
generalszh.exe!GameLogic::reset() Line 416
generalszh.exe!GameEngine::resetSubsystems() Line 811
generalszh.exe!GameEngine::reset() Line 790
generalszh.exe!Win32GameEngine::reset() Line 78
generalszh.exe!GameLogic::clearGameData(bool showScoreScreen) Line 277
generalszh.exe!GameState::loadGame(AvailableGameInfo gameInfo) Line 717
generalszh.exe!doLoadGame() Line 417
generalszh.exe!processLoadButtonPress(GameWindow * window) Line 499
generalszh.exe!SaveLoadMenuSystem(GameWindow * window, unsigned int msg, unsigned int mData1, unsigned int mData2) Line 571
generalszh.exe!GameWindowManager::winSendSystemMsg(GameWindow * window, unsigned int msg, unsigned int mData1, unsigned int mData2) Line 705
generalszh.exe!GadgetListBoxInput(GameWindow * window, unsigned int msg, unsigned int mData1, unsigned int mData2) Line 833
generalszh.exe!GameWindowManager::winSendInputMsg(GameWindow * window, unsigned int msg, unsigned int mData1, unsigned int mData2) Line 724
generalszh.exe!GameWindowManager::winProcessMouseEvent(GameWindowMessage msg, ICoord2D * mousePos, void * data) Line 919
generalszh.exe!WindowTranslator::translateGameMessage(const GameMessage * msg) Line 242
generalszh.exe!MessageStream::propagateMessages() Line 1113
generalszh.exe!GameEngine::update() Line 906
generalszh.exe!Win32GameEngine::update() Line 91
generalszh.exe!GameEngine::execute() Line 984
generalszh.exe!GameMain() Line 55
generalszh.exe!WinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, char * lpCmdLine, int nCmdShow) Line 922

GameLogic::eraseSleepyUpdate is called with -1 for the vector index.