Skip to content

style: Apply consistent field order to AutoHealBehavior Behavior modules#53

Open
Stubbjax wants to merge 2 commits into
TheSuperHackers:mainfrom
Stubbjax:apply-consistent-field-orders-auto-heal-behavior
Open

style: Apply consistent field order to AutoHealBehavior Behavior modules#53
Stubbjax wants to merge 2 commits into
TheSuperHackers:mainfrom
Stubbjax:apply-consistent-field-orders-auto-heal-behavior

Conversation

@Stubbjax
Copy link
Copy Markdown
Contributor

@Stubbjax Stubbjax commented May 29, 2026

This change applies a consistent field order to all AutoHealBehavior Behavior modules across all INI files. Fields are ordered based on the most common order patterns and their code declaration/parse orders.

Order

Below is the order applied to the respective module.

Behavior AutoHealBehavior
  ConflictsWith
  RemovesUpgrades
  FXListUpgrade
  RequiresAllTriggers
  HealingAmount
  HealingDelay
  StartHealingDelay
  SkipSelfForHealing
  AffectsWholePlayer
  TriggeredBy
  Radius
  StartsActive
  KindOf
  ForbiddenKindOf
  SingleBurst
  RadiusParticleSystemName
  UnitHealPulseParticleSystemName

@Stubbjax Stubbjax self-assigned this May 29, 2026
@Stubbjax Stubbjax added Gen Relates to Generals ZH Relates to Zero Hour labels May 29, 2026
@xezon
Copy link
Copy Markdown

xezon commented May 29, 2026

Would be nice if ConflictsWith, RequiresAllTriggers, TriggeredBy sat together

Maybe StartsActive too.

Behavior AutoHealBehavior
  ConflictsWith <---------
  RemovesUpgrades
  FXListUpgrade
  RequiresAllTriggers <---------
  HealingAmount
  HealingDelay
  AffectsWholePlayer
  TriggeredBy <---------
  Radius
  StartsActive <----
  KindOf
  ForbiddenKindOf
  SingleBurst
  RadiusParticleSystemName
  UnitHealPulseParticleSystemName
  StartHealingDelay
  SkipSelfForHealing

@xezon
Copy link
Copy Markdown

xezon commented May 29, 2026

Would have been nice if the healing fields sat together

Behavior AutoHealBehavior
  ConflictsWith
  RemovesUpgrades
  FXListUpgrade
  RequiresAllTriggers
  HealingAmount <-------------
  HealingDelay <-------------
  AffectsWholePlayer
  TriggeredBy
  Radius
  StartsActive
  KindOf
  ForbiddenKindOf
  SingleBurst
  RadiusParticleSystemName
  UnitHealPulseParticleSystemName
  StartHealingDelay <-------------
  SkipSelfForHealing <-------------

@Stubbjax
Copy link
Copy Markdown
Contributor Author

Would be nice if ConflictsWith, RequiresAllTriggers, TriggeredBy sat together

Those are part of UpgradeMuxData:

TriggeredBy
ConflictsWith
RemovesUpgrades
FXListUpgrade
RequiresAllTriggers

I can apply this order across all applicable PRs or do a single second pass?

@xezon
Copy link
Copy Markdown

xezon commented May 29, 2026

Up to you

@Stubbjax
Copy link
Copy Markdown
Contributor Author

Up to you

It probably makes sense to do a second pass, as it will impact all modules that are already in a consistent order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gen Relates to Generals ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants