style: Apply consistent field order to CommandSetUpgrade Behavior modules#55
Merged
Stubbjax merged 1 commit intoMay 30, 2026
Conversation
xezon
approved these changes
May 29, 2026
xezon
reviewed
May 29, 2026
xezon
left a comment
There was a problem hiding this comment.
This pull is labeled for Gen but only contains ZH edits.
|
Would have been nice if TriggeredBy, ConflictsWith, RequiresAllTriggers sat together Although, I see it matches Code definition now. |
Contributor
Author
We could reorder |
|
Keeping it in sync with the Code definition order also makes sense. No strong preference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change applies a consistent field order to all
CommandSetUpgradeBehaviormodules across all INI files. Fields are ordered based on the most common order patterns and their code declaration/parse orders.Note: The invalid modules,
ModuleTag_18andModuleTag_19, inDemo_GLABarrackswill be removed in a future change.Order
Below is the order applied to the respective module.