Skip to content

style: Apply consistent field order to DumbProjectileBehavior Behavior modules#57

Merged
Stubbjax merged 1 commit into
TheSuperHackers:mainfrom
Stubbjax:apply-consistent-field-orders-dumb-projectile-behavior
May 30, 2026
Merged

style: Apply consistent field order to DumbProjectileBehavior Behavior modules#57
Stubbjax merged 1 commit into
TheSuperHackers:mainfrom
Stubbjax:apply-consistent-field-orders-dumb-projectile-behavior

Conversation

@Stubbjax
Copy link
Copy Markdown
Contributor

@Stubbjax Stubbjax commented May 29, 2026

This change applies a consistent field order to all DumbProjectileBehavior Behavior modules across all INI files. Fields are ordered based on the most common order patterns and their code declaration/parse orders.

Order

Below is the order applied to the respective module.

Behavior DumbProjectileBehavior
  MaxLifespan
  TumbleRandomly
  FirstHeight
  SecondHeight
  FirstPercentIndent
  SecondPercentIndent
  GarrisonHitKillRequiredKindOf
  GarrisonHitKillForbiddenKindOf
  GarrisonHitKillCount
  GarrisonHitKillFX
  DetonateCallsKill
  OrientToFlightPath
  FlightPathAdjustDistPerSecond

@Stubbjax Stubbjax self-assigned this May 29, 2026
@Stubbjax Stubbjax added Gen Relates to Generals ZH Relates to Zero Hour labels May 29, 2026
@xezon
Copy link
Copy Markdown

xezon commented May 29, 2026

Maybe would have been nice to group OrientToFlightPath and FlightPathAdjustDistPerSecond together

Behavior DumbProjectileBehavior
  MaxLifespan
  TumbleRandomly
  OrientToFlightPath <----------
  FirstHeight
  SecondHeight
  FirstPercentIndent
  SecondPercentIndent
  GarrisonHitKillRequiredKindOf
  GarrisonHitKillForbiddenKindOf
  GarrisonHitKillCount
  GarrisonHitKillFX
  DetonateCallsKill
  FlightPathAdjustDistPerSecond <----------

@Stubbjax
Copy link
Copy Markdown
Contributor Author

Maybe would have been nice to group OrientToFlightPath and FlightPathAdjustDistPerSecond together

I've adjusted the order, though OrientToFlightPath does not exist in the data. It may be effectively superseded by setting FlightPathAdjustDistPerSecond = 0.0.

I also wonder whether the five shared fields with MissileAIUpdate should be grouped.

@Stubbjax Stubbjax force-pushed the apply-consistent-field-orders-dumb-projectile-behavior branch from 15b631e to 81a011e Compare May 30, 2026 04:18
@Stubbjax Stubbjax merged commit 2666e23 into TheSuperHackers:main May 30, 2026
@Stubbjax Stubbjax deleted the apply-consistent-field-orders-dumb-projectile-behavior branch May 30, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gen Relates to Generals ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants