Skip to content

style: Apply consistent field order to FireWeaponWhenDeadBehavior Behavior modules#61

Merged
Stubbjax merged 1 commit into
TheSuperHackers:mainfrom
Stubbjax:apply-consistent-field-orders-fire-weapon-when-dead-behavior
May 30, 2026
Merged

style: Apply consistent field order to FireWeaponWhenDeadBehavior Behavior modules#61
Stubbjax merged 1 commit into
TheSuperHackers:mainfrom
Stubbjax:apply-consistent-field-orders-fire-weapon-when-dead-behavior

Conversation

@Stubbjax
Copy link
Copy Markdown
Contributor

This change applies a consistent field order to all FireWeaponWhenDeadBehavior Behavior modules across all INI files. Fields are ordered based on the most common order patterns and their code declaration/parse orders.

Order

Below is the order applied to the respective module.

Behavior FireWeaponWhenDeadBehavior
  RequiredStatus
  ExemptStatus
  DeathWeapon
  StartsActive
  TriggeredBy
  RequiresAllTriggers
  ConflictsWith
  RemovesUpgrades
  FXListUpgrade
  DeathTypes
  VeterancyLevels

@Stubbjax Stubbjax self-assigned this May 29, 2026
@Stubbjax Stubbjax added Gen Relates to Generals ZH Relates to Zero Hour labels May 29, 2026
@xezon
Copy link
Copy Markdown

xezon commented May 29, 2026

It is a bit unfortunate that the ExemptStatus and RequiredStatus are not consistently ordered:

Behavior FireWeaponWhenDeadBehavior
  RequiredStatus <----------
  ExemptStatus <----------
  DeathWeapon
  StartsActive
  TriggeredBy
  RequiresAllTriggers
  ConflictsWith
  RemovesUpgrades
  FXListUpgrade
  DeathTypes
  VeterancyLevels

Behavior EjectPilotDie
  DeathTypes
  VeterancyLevels
  GroundCreationList
  AirCreationList
  ExemptStatus <----------
  RequiredStatus <----------
  InvulnerableTime

@xezon
Copy link
Copy Markdown

xezon commented May 29, 2026

Would have been nice if DeathTypes and DeathWeapon sat together

Behavior FireWeaponWhenDeadBehavior
  RequiredStatus
  ExemptStatus
  DeathWeapon <--------
  StartsActive
  TriggeredBy
  RequiresAllTriggers
  ConflictsWith
  RemovesUpgrades
  FXListUpgrade
  DeathTypes <--------
  VeterancyLevels

@Stubbjax
Copy link
Copy Markdown
Contributor Author

It is a bit unfortunate that the ExemptStatus and RequiredStatus are not consistently ordered:

I tend to agree, though I was primarily attempting to align them using the existing patterns within their own modules. I can apply the DieMuxData format to each individual module/PR or I can do a single follow-up standardisation?

DeathTypes
VeterancyLevels
ExemptStatus
RequiredStatus

@xezon
Copy link
Copy Markdown

xezon commented May 29, 2026

Up to you

@Stubbjax Stubbjax merged commit cf47eeb into TheSuperHackers:main May 30, 2026
@Stubbjax Stubbjax deleted the apply-consistent-field-orders-fire-weapon-when-dead-behavior branch May 30, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gen Relates to Generals ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants