Skip to content

style: Apply consistent field order to FXListDie Behavior modules#62

Merged
Stubbjax merged 1 commit into
TheSuperHackers:mainfrom
Stubbjax:apply-consistent-field-orders-fx-list-die
May 30, 2026
Merged

style: Apply consistent field order to FXListDie Behavior modules#62
Stubbjax merged 1 commit into
TheSuperHackers:mainfrom
Stubbjax:apply-consistent-field-orders-fx-list-die

Conversation

@Stubbjax
Copy link
Copy Markdown
Contributor

This change applies a consistent field order to all FXListDie Behavior modules across all INI files. Fields are ordered based on the most common order patterns and their code declaration/parse orders.

Order

Below is the order applied to the respective module.

Behavior FXListDie
  DeathTypes
  VeterancyLevels
  DeathFX
  ExemptStatus
  RequiredStatus
  StartsActive
  OrientToObject
  TriggeredBy
  ConflictsWith
  RemovesUpgrades
  FXListUpgrade
  RequiresAllTriggers

@Stubbjax Stubbjax self-assigned this May 29, 2026
@Stubbjax Stubbjax added Gen Relates to Generals ZH Relates to Zero Hour labels May 29, 2026
@xezon
Copy link
Copy Markdown

xezon commented May 29, 2026

Would have been nice if TriggeredBy, ConflictsWith and RequiresAllTriggers sat together

Behavior FXListDie
  DeathTypes
  VeterancyLevels
  DeathFX
  ExemptStatus
  RequiredStatus
  StartsActive
  OrientToObject
  TriggeredBy <------------
  ConflictsWith <------------
  RemovesUpgrades
  FXListUpgrade
  RequiresAllTriggers <------------

@Stubbjax Stubbjax merged commit 2021164 into TheSuperHackers:main May 30, 2026
@Stubbjax Stubbjax deleted the apply-consistent-field-orders-fx-list-die branch May 30, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gen Relates to Generals ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants