docs: Upgrade Docker guide to use Ninja#77
Open
misterhackerman wants to merge 2 commits intoTheSuperHackers:mainfrom
Open
docs: Upgrade Docker guide to use Ninja#77misterhackerman wants to merge 2 commits intoTheSuperHackers:mainfrom
misterhackerman wants to merge 2 commits intoTheSuperHackers:mainfrom
Conversation
Contributor
Author
|
solves #76 |
Contributor
|
Does this replace building with VS6? Since the guide seems to be designed for building with VS6, so maybe a separate guide dedicated to Ninja is needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
build_with_msvc6_on_docker.mdguide to utilize modern build tools and LTS package sources.Key Changes
NMaketoNinja.ninja-win.zip.-G "Ninja".noble(Ubuntu 24.04) to ensure compatibility with the LTS base image.CMDto exec form (["tail", ...]) for better process handling.