Fix #339: drop Bazel 7 support and bump protobuf to 35.0#364
Open
tinder-maxwellelliott wants to merge 1 commit into
Open
Fix #339: drop Bazel 7 support and bump protobuf to 35.0#364tinder-maxwellelliott wants to merge 1 commit into
tinder-maxwellelliott wants to merge 1 commit into
Conversation
Bazel 7 is removed from CI (test-jre11-run-example matrix), BCR presubmit, and README prerequisites. With Bazel 7 gone, protobuf can move up to 35.0 (which requires Bazel >=8.0.0), picking up the sun.misc.Unsafe graceful-fallback path. The full Unsafe removal protobuf#20760 is still pending upstream, so the bump is the preparatory step rather than the final silencing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-jre11-run-examplematrix), BCR presubmit, and the README's stated prerequisites (now Bazel 8.x or higher).protobuffrom33.4→35.0inMODULE.bazel, andcom_google_protobuffrom26.1→35.0inrepositories.bzl. Protobuf 35.0 requires Bazel >= 8.0.0, which is why the Bazel 7 drop is bundled here.MODULE.bazel.lockto pin protobuf 35.0 and the transitive bumps it pulls in (apple_support 2.3.0, rules_cc 0.2.15, rules_kotlin 2.3.20, rules_rust 0.69.0, jsoncpp 1.9.6.bcr.2).What this does for #339 / protobuf#20760
Protobuf 35.0 adds the runtime check that lets the Java runtime fall back gracefully under
--sun-misc-unsafe-memory-access=deny, but it still callssun.misc.Unsafe::arrayBaseOffseton its happy path, so the JDK 24+ deprecation warning is not yet silenced by this bump alone. Upstream protobuf#20760 is still open; the protobuf team has stated the full removal from JavaProto-full is targeted for a future minor release. This PR puts bazel-diff on the latest line so picking up that fix becomes a one-line change.Test plan
bazel build //cli:bazel-diff_deploy.jarsucceeds locallycom/google/protobuf/UnsafeUtil.classis the v35.0 version (contains the new--sun-misc-unsafe-memory-access=allowfallback strings)🤖 Generated with Claude Code