Skip to content

fix: Disable clazy check as it is missing cmake dependencies.

1dacf2d
Select commit
Loading
Failed to load commit list.
Merged

fix: Disable clazy check as it is missing cmake dependencies. #161

fix: Disable clazy check as it is missing cmake dependencies.
1dacf2d
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Dec 21, 2025 in 0s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : fix: Disable clazy check as it is missing cmake dependencies.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : fix: Disable clazy check as it is missing cmake dependencies.
    Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : ### Clazy changes
    In the restylers configuration , staring from v0.597.0 (2025-09-19) the new linter clazy was introduced. It relies on the pre built docker image, which is missing some dependencies, including PkgConfig.
    In this PR I have disabled the linter for now, however, the longer term solution would be to use docker image, which supports building qTox.

Currently CI/CD will always fail with the error

CMake Error at /usr/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
Call Stack (most recent call first):
  /usr/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.31/Modules/FindPkgConfig.cmake:114 (find_package_handle_standard_args)
  cmake/Dependencies.cmake:12 (find_package)
  CMakeLists.txt:194 (include)

This change is Reviewable

Changes to mypy

There were some insignificant changes related to minidom typing, which used to break the CI/CD. I have added two type fixes to pass.

Changes for python linters

The new version of restyled also introduces several python linters i.e. autopep8, black, etc.
Most of changes in the tools/translate.py are caused by black.
I had to disable several python linters in restyled as without additional parameters they conflict with each other. For example black will reformat file, which will always be reformatted with yapf.
Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}