Pretty-print equations in models of discrete theories#1085
Merged
Conversation
03a8dc5 to
cfc70d8
Compare
KevinDCarlson
commented
Feb 28, 2026
If we're going to change this, we need to do so consistently across the codebase and I don't that's the worth the effort right now.
epatters
approved these changes
Mar 16, 2026
Member
epatters
left a comment
There was a problem hiding this comment.
Thanks! I've cleaned this up by upgrading FgDblModel to FpDblModel and adding a method equation to that trait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pretty-prints equations in discrete double models for the first time. An example is being tested in the snapshot test
test_equality.dbltt, which exhibits output looking like so:Arguably the suffix could be any of
: NW -> SE(Hom Entity)(NW,SE)Hom Entity NW SE, or if we modify the morphism type printing, `Hom(Entity)(NW,SE).I think the last option is probably my favorite.
(EDIT: commit added to pick the last option.)