Open
Conversation
abuntakov
requested changes
Nov 18, 2021
.../src/main/kotlin/ru/touchin/spring/workers/manager/agent/annotation_config/DefaultTrigger.kt
Outdated
Show resolved
Hide resolved
...rs-manager-agent/src/main/kotlin/ru/touchin/spring/workers/manager/agent/AgentInitializer.kt
Outdated
Show resolved
Hide resolved
...-core/src/main/kotlin/ru/touchin/spring/workers/manager/core/repositories/RepositoryUtils.kt
Outdated
Show resolved
Hide resolved
abuntakov
requested changes
Dec 3, 2021
...nt/src/main/kotlin/ru/touchin/spring/workers/manager/agent/scheduled/WorkerManagerWatcher.kt
Outdated
Show resolved
Hide resolved
...ers-manager-core/src/main/kotlin/ru/touchin/spring/workers/manager/core/worker/dto/Worker.kt
Outdated
Show resolved
Hide resolved
abuntakov
approved these changes
Dec 3, 2021
| * Annotation to enable Workers Manager module in Spring components via annotations. | ||
| */ | ||
| @Import(WorkersManagerConfiguration::class) | ||
| annotation class EnableWorkersManager |
There was a problem hiding this comment.
instead of using @Enable... annotation you can simply add your configuration to spring.factories.
example: https://github.com/vladimirshefer/spring-boot-starter-telegram/blob/master/spring-boot-starter-telegram/src/main/resources/META-INF/spring.factories
| * Glob is simple replacement for Regex. | ||
| * It uses only two special chars: * (any substring) and ? (any char) | ||
| * This implementation has no support for characters escaping. | ||
| * Glob has no capturing features. |
There was a problem hiding this comment.
please add @author Vladimir Shefer to the javadoc :)
| * Glob is simple replacement for Regex. | ||
| * It uses only two special chars: * (any substring) and ? (any char) | ||
| * This implementation has no support for characters escaping. | ||
| * Glob has no capturing features. |
There was a problem hiding this comment.
Suggested change
| * Glob has no capturing features. | |
| * Glob has no capturing features. | |
| * @author Vladimir Shefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.