Add option in filter settings to show froxzen (disabled) apps#556
Open
nmarteybotchway wants to merge 1 commit intoTrackerControl:masterfrom
Open
Add option in filter settings to show froxzen (disabled) apps#556nmarteybotchway wants to merge 1 commit intoTrackerControl:masterfrom
nmarteybotchway wants to merge 1 commit intoTrackerControl:masterfrom
Conversation
Contributor
Author
|
Hey @kasnder - another small change here. Would really appreciate your thoughts when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #433
Summary
Adds a new "Show frozen apps" filter checkbox to the main app list,
allowing users to view and configure firewall rules for disabled/frozen
apps without needing to unfreeze them first.
Problem
Previously, disabled (frozen) apps were completely hidden from
TrackerControl's app list. This made it impossible to:
every disabled app
Changes
res/menu/main.xml: Addedmenu_app_frozencheckbox item to thefilter submenu, below "Show apps without internet"
res/values/strings.xml: Addedmenu_show_frozenstring resourceActivityMain.javaonPrepareOptionsMenu: Added checked state forthe new checkbox
ActivityMain.javaonOptionsItemSelected: Added handler that writesshow_frozento SharedPreferences when toggledActivityMain.javaonSharedPreferenceChanged: Addedshow_frozento the preference change listener so the list refreshes automatically
when toggled
Rule.javagetRules(): Addedshow_frozenpreference read andupdated the filter condition from
rule.enabledto(show_frozen || rule.enabled)so disabled apps are included whenthe option is on
Behaviour
preserved
fully configurable
Testing