Fix/ibkr forex contract resolution#345
Open
jalilsedna wants to merge 2 commits into
Open
Conversation
Comment out the VOLUME instruction for /data in Dockerfile.
placeOrder sent bare { conId, symbol } contracts to TWS with a naive
SMART/USD default, so forex (CASH/IDEALPRO, e.g. USDCHF) was rejected
with "error 200: No security definition has been found". getQuote already
resolved the same input correctly via reqContractDetails.
Extract that resolution into a shared resolveFullContract() and call it
from both placeOrder (inside the try, so a resolution failure returns a
clean error and never places a naked order) and getQuote, so the quote
and order paths can no longer diverge. CASH defaults to IDEALPRO, all
else to SMART; conId-without-secType round-trips through getContractDetails
once and is cached.
The attached TP/SL (bracket) refusal is unchanged - FX flow stays
entry-first, then standalone protective orders.
Tests: Case A (bare USDCHF conId -> CASH/IDEALPRO/USD.CHF, matches
getContractDetails), Case B (typed AAPL STK passes through unchanged, no
round-trip).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
@jalilsedna is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix/ibkr forex contract resolution