Fix TransformerBridge backward hook cleanup#1324
Open
SamuelePunzo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
TransformerBridgebackward-hook cleanup so temporary backward hooks do not leak after context exit.HookPoint.remove_hooks()defaults to forward-only cleanup, andTransformerBridgewas calling it without an explicit direction in several cleanup paths. Thatmeant non-permanent backward hooks could remain attached after
with model.hooks(...)exited, andreset_hooks()on bridge components could also miss backwardhooks.
This change:
TransformerBridge.hooks(...)TransformerBridge.run_with_hooks(...)run_with_cache(...)teardown by cleaning up only the forward cache hooks it addsreset_hooks(), andrun_with_cache(...)This fixes the bug reported in the linked issue. No additional dependencies are required.
Fixes #1323
Type of change
Screenshots
Not applicable.
Checklist: