publish(9.0.3): fix peerDep angular router for v14#121
publish(9.0.3): fix peerDep angular router for v14#121TPullen21 wants to merge 1 commit intoTrilonIO:masterfrom
Conversation
|
@MarkPieszak Can this be reviewed and merged? |
|
bump. Would like this merged as well. any issues? |
|
When will this be merged >.<? |
|
@MarkPieszak how can I help get this merged? |
|
Is it possible to merge this branch soon? |
|
why do people even use peer dependency range? I mean why not simply use a minimal greater than version instead of a fixed version? Because trying to upgrade to future version like Angular 15 throws install error because of this peer dependency requirement, so unless I use a --force install it bugs down our installation. On another end, in my own Angular libs, I simply never use any peer deps to avoid such problems, but even if we really want to use peer deps, then why not use something simpler like this: "@angular/router": ">=10.0.0"at least this would work with current and future versions instead of requiring a code change and new version every time a new Angular major release is out which is twice a year. This approach would require a lot less maintenance too |
|
@TPullen21 can you complete this PR? |
|
@wolfpackt99 I don't have the rights to complete, it's up to @MarkPieszak. |
|
@MarkPieszak |
Resolves #119