Skip to content

Implement parsing of 2.5.5 #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
killerwife wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Implement parsing of 2.5.5 #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
575cc69
Ugly v1 of 255
killerwife Dec 22, 2025
6fa5da8
Fix update parsing of channel for 1.15.8
killerwife Jan 4, 2026
329cfcd
Add V2_5_5_65417
killerwife Jan 16, 2026
e272d68
Add support for all create and update up to unit and smsg monster move
killerwife Feb 8, 2026
65ecb94
Implement and fixup parsing of all listed other packets
killerwife Feb 8, 2026
9e90fbc
Fixup rest of critical parsing
killerwife Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions WowPacketParser/Enums/ClientVersionBuild.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,6 +892,13 @@ public enum ClientVersionBuild
V2_5_4_44400 = 44400, // both live and ptr
V2_5_4_44833 = 44833, // both live and ptr

V2_5_5_64796 = 64796, // ptr
V2_5_5_64912 = 64912, // ptr
V2_5_5_65000 = 65000, // ptr
V2_5_5_65417 = 65417, // ptr and live
V2_5_5_65676 = 65676, // live
V2_5_5_65795 = 65795, // live

V3_4_0_44832 = 44832, // ptr / beta
V3_4_0_45166 = 45166, // ptr / beta
V3_4_0_45189 = 45189, // ptr / beta
Expand Down
10 changes: 10 additions & 0 deletions WowPacketParser/Enums/Version/Opcodes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
using WowPacketParser.Enums.Version.V11_2_7_64877;
using WowPacketParser.Enums.Version.V12_0_0_65390;
using WowPacketParser.Misc;
using WowPacketParser.Enums.Version.V2_5_5_64796;

namespace WowPacketParser.Enums.Version
{
Expand Down Expand Up @@ -1214,6 +1215,13 @@ public static ClientVersionBuild GetOpcodeDefiningBuild(ClientVersionBuild build
case ClientVersionBuild.V5_5_2_64271:
case ClientVersionBuild.V5_5_2_64481:
return ClientVersionBuild.V5_5_2_64068;
case ClientVersionBuild.V2_5_5_64796:
case ClientVersionBuild.V2_5_5_64912:
case ClientVersionBuild.V2_5_5_65000:
case ClientVersionBuild.V2_5_5_65417:
case ClientVersionBuild.V2_5_5_65676:
case ClientVersionBuild.V2_5_5_65795:
return ClientVersionBuild.V2_5_5_64796;
default:
return ClientVersionBuild.V3_3_5a_12340;
}
Expand Down Expand Up @@ -1411,6 +1419,8 @@ public static BiDictionary<Opcode, int> GetOpcodeDictionary(ClientVersionBuild b
return Opcodes_2_5_3.Opcodes(direction);
case ClientVersionBuild.V2_5_4_42695:
return Opcodes_2_5_4.Opcodes(direction);
case ClientVersionBuild.V2_5_5_64796:
return Opcodes_2_5_5.Opcodes(direction);
case ClientVersionBuild.V3_4_0_45166:
return Opcodes_3_4_0.Opcodes(direction);
case ClientVersionBuild.V3_4_1_47014:
Expand Down
9 changes: 9 additions & 0 deletions WowPacketParser/Enums/Version/UpdateFields.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,15 @@ private static string GetUpdateFieldDictionaryBuildName(ClientVersionBuild build
{
return "V2_5_4_42800";
}
case ClientVersionBuild.V2_5_5_64796:
case ClientVersionBuild.V2_5_5_64912:
case ClientVersionBuild.V2_5_5_65000:
case ClientVersionBuild.V2_5_5_65417:
case ClientVersionBuild.V2_5_5_65676:
case ClientVersionBuild.V2_5_5_65795:
{
return "V2_5_5_64796";
}
case ClientVersionBuild.V3_4_0_45166:
case ClientVersionBuild.V3_4_0_44832:
case ClientVersionBuild.V3_4_0_45189:
Expand Down
42 changes: 42 additions & 0 deletions WowPacketParser/Enums/Version/V2_5_5_64796/Opcodes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
using WowPacketParser.Misc;

namespace WowPacketParser.Enums.Version.V2_5_5_64796
{
public static class Opcodes_2_5_5
{
public static BiDictionary<Opcode, int> Opcodes(Direction direction)
{
switch (direction)
{
case Direction.ClientToServer:
return ClientOpcodes;
case Direction.ServerToClient:
return ServerOpcodes;
default:
return MiscOpcodes;
}
}

private static readonly BiDictionary<Opcode, int> ClientOpcodes = new()
{
{ Opcode.CMSG_CHAT_MESSAGE_SAY, 0x2F0023 },
{ Opcode.CMSG_SEND_TEXT_EMOTE, 0x3E0013 },
{ Opcode.CMSG_USE_ITEM, 0x30016B },
};

private static readonly BiDictionary<Opcode, int> ServerOpcodes = new()
{
{ Opcode.SMSG_TEXT_EMOTE, 0x440121 },
{ Opcode.SMSG_EMOTE, 0x440270 },
{ Opcode.SMSG_CHAT, 0x490001 },
{ Opcode.SMSG_ON_MONSTER_MOVE, 0x5C0002 },
{ Opcode.SMSG_UPDATE_OBJECT, 0x5A0000 },
{ Opcode.SMSG_AURA_UPDATE, 0x630011 },
{ Opcode.SMSG_SPELL_GO, 0x630028 },
{ Opcode.SMSG_SPELL_START, 0x630029 },
{ Opcode.SMSG_PET_SPELLS_MESSAGE, 0x630014 },
};

private static readonly BiDictionary<Opcode, int> MiscOpcodes = new();
}
}
12 changes: 12 additions & 0 deletions WowPacketParser/Misc/ClientVersion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1665,6 +1665,12 @@ public static ClientVersionBuild GetVersionDefiningBuild(ClientVersionBuild buil
case ClientVersionBuild.V1_15_8_64272:
case ClientVersionBuild.V1_15_8_64858:
case ClientVersionBuild.V1_15_8_64907:
case ClientVersionBuild.V2_5_5_64796:
case ClientVersionBuild.V2_5_5_64912:
case ClientVersionBuild.V2_5_5_65000:
case ClientVersionBuild.V2_5_5_65417:
case ClientVersionBuild.V2_5_5_65676:
case ClientVersionBuild.V2_5_5_65795:
return ClientVersionBuild.V5_5_0_61735;
case ClientVersionBuild.BattleNetV37165:
return ClientVersionBuild.BattleNetV37165;
Expand Down Expand Up @@ -2159,6 +2165,12 @@ public static bool IsBurningCrusadeClassicClientVersionBuild(ClientVersionBuild
case ClientVersionBuild.V2_5_4_44171:
case ClientVersionBuild.V2_5_4_44400:
case ClientVersionBuild.V2_5_4_44833:
case ClientVersionBuild.V2_5_5_64796:
case ClientVersionBuild.V2_5_5_64912:
case ClientVersionBuild.V2_5_5_65000:
case ClientVersionBuild.V2_5_5_65417:
case ClientVersionBuild.V2_5_5_65676:
case ClientVersionBuild.V2_5_5_65795:
return true;
default:
return false;
Expand Down
1 change: 1 addition & 0 deletions WowPacketParserModule.V5_5_0_61735/Parsers/MovementHandler1158.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ public static void ReadMoveStateChange(Packet packet, params object[] idx)
}

[Parser(Opcode.SMSG_ON_MONSTER_MOVE, ClientBranch.Classic)]
[Parser(Opcode.SMSG_ON_MONSTER_MOVE, ClientBranch.TBC)]
public static void HandleOnMonsterMove(Packet packet)
{
PacketMonsterMove monsterMove = packet.Holder.MonsterMove = new();
Expand Down
4 changes: 2 additions & 2 deletions WowPacketParserModule.V5_5_0_61735/Parsers/SpellHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@ public static void HandleSpellDispelLog(Packet packet)
}

[HasSniffData]
[Parser(Opcode.SMSG_AURA_UPDATE)]
[Parser(Opcode.SMSG_AURA_UPDATE, ClientBranch.MoP)]
public static void HandleAuraUpdate(Packet packet)
{
PacketAuraUpdate packetAuraUpdate = packet.Holder.AuraUpdate = new();
Expand Down Expand Up @@ -1064,7 +1064,7 @@ public static void SpellPrepare(Packet packet)
packet.ReadPackedGuid128("ServerCastID");
}

[Parser(Opcode.SMSG_SPELL_GO)]
[Parser(Opcode.SMSG_SPELL_GO, ClientBranch.MoP)]
public static void HandleSpellGo(Packet packet)
{
PacketSpellGo packetSpellGo = new();
Expand Down
Loading