Use the correct form of sha1.Sum #87
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sha1.New().Sum(x) appends a hash of nothing to x. See https://go.dev/play/p/h6pGFHEzbfA
|
这是来自QQ邮箱的自动回复邮件。谢谢你的邮件，我会尽快查看
|
mcsaucy
added a commit
to mcsaucy/DocHub
that referenced
this pull request
Apr 16, 2025
Its implementation is incorrect (see TruthHun#87) and it doesn't appear to be used.
Open
Author
|
Checking again, I think this is dead code so closing in favor of #88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sha1.New().Sum(x) appends a hash of nothing to x.
See https://go.dev/play/p/h6pGFHEzbfA