SharkPool/Camera.js -- Add touch precision block, optimize, and improve code

[SharkPool-SP]

• adds a block for precise collisions
• optimizations with dirty checks
• cleaner code
• fix minor floating point issues
• allow setting alpha color of the canvas

[SharkPool-SP]

!format

[Brackets-Coder]

Okay, I'll look into it when I have time

[Brackets-Coder]

Quick skim. Code looks better now, I just have to find time to test and make sure everything's still working

I don't have any older projects with this extension so I can't do much regression testing :/

[SharkPool-SP]

!format

[SharkPool-SP]

@Brackets-Coder Use this sb3 (rename .zip to .sb3) which has the old version. Try it out, notice the jitter.

New version of the extension is more optimized, and enabling precise touch mode fixes the jitter.

platfor.zip

[RedMan13]

i cant seem to unbind this sprite from the default camera, even though the block suggest i could

[SharkPool-SP]

i cant seem to unbind this sprite from the default camera, even though the block suggest i could

I could change that in this update

[RedMan13]

i dont think unbinding from a camera the sprite isnt even bound too is supposed to reset to the default camera

[RedMan13]

I could change that in this update

alr

[SharkPool-SP]

I could change that in this update

alr

I just hid the block since this block is technically just a bind block to the default camera.

[SharkPool-SP]

!format

[github-actions]

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

[RedMan13]

I just hid the block since this block is technically just a bind block to the default camera.

alr, ig

[RedMan13]

i cant see any issues, and the changes seem perfectly fine to me

[Brackets-Coder]

@Brackets-Coder Use this sb3 (rename .zip to .sb3) which has the old version. Try it out, notice the jitter.

New version of the extension is more optimized, and enabling precise touch mode fixes the jitter.

platfor.zip

I'll get to you as soon as I can, may be a few days

[SharkPool-SP]

@Brackets-Coder Use this sb3 (rename .zip to .sb3) which has the old version. Try it out, notice the jitter.

New version of the extension is more optimized, and enabling precise touch mode fixes the jitter.

platfor.zip

I'll get to you as soon as I can, may be a few days

Few days later

[Brackets-Coder]

I'll take a look now, thanks for the reminder

[Brackets-Coder]

Aside from the sketchy platformer physics provided in the demo, the most recent commit of the camera extension looks good. Enabling the new touch precision block entirely mitigates the sketchy physics and makes it buttery smooth. Nice job.

• I tested all modified functionality and found no bugs or unintuitive behavior.
  • I tested the provided demo project with the newly added block, I haven't yet manually confirmed that the other blocks (zoom, direction, etc). are still working as expected.
• I believe a well-formed project using an older version of this extension will not be broken by this new version.
• I have no additional concerns.

Below you can see that the player "bounces" off of the wall when constantly pressing D to move right into it. This only happens with the new precision mode enabled. It's better than clipping through the wall or bouncing to the top (which happens without it) but I was wondering if you could make the player not move in such circumstances? Is this a project limitation or extension limitation? I'm not familiar with how this extension works, so to be honest I'm not the best one to be reviewing this

video.webm

[SharkPool-SP]

Aside from the sketchy platformer physics provided in the demo, the most recent commit of the camera extension looks good. Enabling the new touch precision block entirely mitigates the sketchy physics and makes it buttery smooth. Nice job.

• I tested all modified functionality and found no bugs or unintuitive behavior.

  • I tested the provided demo project with the newly added block, I haven't yet manually confirmed that the other blocks (zoom, direction, etc). are still working as expected.

• I believe a well-formed project using an older version of this extension will not be broken by this new version.

• I have no additional concerns.

Below you can see that the player "bounces" off of the wall when constantly pressing D to move right into it. This only happens with the new precision mode enabled. It's better than clipping through the wall or bouncing to the top (which happens without it) but I was wondering if you could make the player not move in such circumstances? Is this a project limitation or extension limitation? I'm not familiar with how this extension works, so to be honest I'm not the best one to be reviewing this

video.webm

That is not entirely an issue with the extension, it still happens when the zoom is at the default 100. You can barely see it but it does happen. It becomes more visible because of non-rounded camera xy values multiplied by the camera zoom

[SharkPool-SP]

!format

[Brackets-Coder]

@SharkPool-SP can it wait until next week?

[SharkPool-SP]

@SharkPool-SP can it wait until next week?

Idk

[SharkPool-SP]

@SharkPool-SP can it wait until next week?

Vro 🙏

[DogeisCut]

• I tested all modified functionality and found no bugs or unintuitive behavior.
• I believe a well-formed project using an older version of this extension will not be broken by this new version.
• I have no additional concerns.

[Brackets-Coder]

@SharkPool-SP can it wait until next week?

Vro 🙏

Thx for the reminder I'll get it sometime this afternoon or tomorrow afternoon

[GarboMuffin]

yolo

a

[Brackets-Coder]

Nevermind I won't get it this afternoon then

[SharkPool-SP]

yolo

Garbs finally understands life 🥹