Fix wxWidgets subproject build#573
Merged
arch1t3cht merged 2 commits intoTypesettingTools:masterfrom Mar 5, 2026
Merged
Conversation
The available targets depend on platform and wxWidgets version. Instead of trying to guess, let's detect which targets are available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #555.
The toolkit detection is fixed by removing sources from the dependency with
partial_dependency. This happens to work because of obscure meson implementation details.The nonexistent target is fixed by adding logic to detect if the target exists. With the detection logic in place, I've also added
wxlexillato the list of dependencies, since it's needed for wxWidgets 3.3 and with the detection logic, it won't break wxWidgets 3.2.The conditionally added
wxpng,wxzlibandwxexpatcould maybe be converted to also use this detection logic instead of hardcoding which platforms they are needed on, but I'm not sure and didn't want to break anything that works, so I kept it as is.