fix(ui5-shellbar): correct icon color in overflow popover#13517
Open
NakataCode wants to merge 1 commit into
Open
fix(ui5-shellbar): correct icon color in overflow popover#13517NakataCode wants to merge 1 commit into
NakataCode wants to merge 1 commit into
Conversation
Collaborator
|
🚀 Deployed on https://pr-13517--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
--sapShell_TextColorfrom the shell header, causing them to appear in the wrong color against the popover's light background.Solution:
--sapList_TextColorinside the overflow popover, consistent with the existing[ui5-li]::part(icon)rule and aligned with the VD spec requirement that overflow icons match the list text color.JIRA: BGSOFUIPIRIN-7069