Skip to content

Standardize create note form fields#72

Merged
TyHil merged 6 commits intodevelopfrom
standardized-form-components-everywhere-notebook-requested-by-tyler
Feb 13, 2026
Merged

Standardize create note form fields#72
TyHil merged 6 commits intodevelopfrom
standardized-form-components-everywhere-notebook-requested-by-tyler

Conversation

@SinhSinhAn
Copy link
Copy Markdown
Contributor

requested by Tyler, from notebook TanStack format

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
utd-notebook Ready Ready Preview, Comment Feb 13, 2026 11:11pm

Request Review

@SinhSinhAn SinhSinhAn requested a review from TyHil February 1, 2026 21:40
@SinhSinhAn SinhSinhAn closed this Feb 9, 2026
@SinhSinhAn SinhSinhAn deleted the standardized-form-components-everywhere-notebook-requested-by-tyler branch February 9, 2026 07:31
@TyHil
Copy link
Copy Markdown
Member

TyHil commented Feb 9, 2026

Wait why'd you close this, it looked good

@SinhSinhAn
Copy link
Copy Markdown
Contributor Author

wait crap, I accidentally closed the wrong branch

@SinhSinhAn
Copy link
Copy Markdown
Contributor Author

Can you reopen this and reviw this pr for me por favor?

@TyHil TyHil restored the standardized-form-components-everywhere-notebook-requested-by-tyler branch February 9, 2026 20:43
@TyHil TyHil reopened this Feb 9, 2026
Copy link
Copy Markdown
Member

@TyHil TyHil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this all works but it looks like this on the page:

Image

Can you add className="w-full" to the three field.TextFields

@TyHil
Copy link
Copy Markdown
Member

TyHil commented Feb 9, 2026

Can you copy over this change from your other PR too

UTDNebula/utd-clubs#581 (comment)

in components/form/FormTextField and src/app/notes/create/CreateNoteForm.tsx

@SinhSinhAn
Copy link
Copy Markdown
Contributor Author

Made the Name, Description, and Section text fields stretch to full width in the create note form instead of being a fixed narrow size. Also updated the shared StyledTextField component so that its default width can actually be overridden when needed. and Yes i used claude to find the damn form

@TyHil
Copy link
Copy Markdown
Member

TyHil commented Feb 10, 2026

Was the change to src\components\form\FormTextField.tsx necessary? The width got overridden correctly when I added w-full for testing. The way you've implemented it we'd lose w-64 if any extra className is provided. If it is necessary, there's an example of a better way to do it in src\components\common\BaseCard.tsx with hasBgClass.

@SinhSinhAn
Copy link
Copy Markdown
Contributor Author

Can you tell design is not my cup of tea, esspecially after getting mauled by Issac in code review, I'll fix it

@SinhSinhAn SinhSinhAn force-pushed the standardized-form-components-everywhere-notebook-requested-by-tyler branch from 7c4ff49 to 7667a30 Compare February 10, 2026 00:32
@TyHil
Copy link
Copy Markdown
Member

TyHil commented Feb 10, 2026

Hahaha, ty. Last thing is this:

Can you copy over this change from your other PR too

UTDNebula/utd-clubs#581 (comment)

in components/form/FormTextField and src/app/notes/create/CreateNoteForm.tsx

Try not to force push tho, it's generally bad practice

@SinhSinhAn
Copy link
Copy Markdown
Contributor Author

will do!

@SinhSinhAn
Copy link
Copy Markdown
Contributor Author

Hey just following up, every looks like it's addressed, lmk if there's something else needs to be changed

@SinhSinhAn
Copy link
Copy Markdown
Contributor Author

alright just changed it to full width, mb forgetting about the comment from before, lmk if you need anything else!

Copy link
Copy Markdown
Member

@TyHil TyHil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@TyHil TyHil merged commit 98063b6 into develop Feb 13, 2026
3 checks passed
@TyHil TyHil deleted the standardized-form-components-everywhere-notebook-requested-by-tyler branch February 13, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants