Speed up UR5e analytical Jacobian path for OmniReset RelCartesianOSC#30
Open
AbdelStark wants to merge 2 commits intoUW-Lab:mainfrom
Open
Speed up UR5e analytical Jacobian path for OmniReset RelCartesianOSC#30AbdelStark wants to merge 2 commits intoUW-Lab:mainfrom
AbdelStark wants to merge 2 commits intoUW-Lab:mainfrom
Conversation
Signed-off-by: AbdelStark <AbdelStark@users.noreply.github.com>
Signed-off-by: AbdelStark <AbdelStark@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accelerates the analytical Jacobian path used by
RelCartesianOSCActionin OmniReset UR5e tasks.The previous implementation rebuilt batched
4x4calibrated transforms on every physics step. This change replaces that path with a device/dtype-cached recurrence over rotation and translation, so the control loop reuses calibrated constants instead of reconstructing them for every Jacobian evaluation.What changed:
uwlab_assets.robots.ur5e_robotiq_gripper.kinematicscompute_jacobian_analytical()to avoid repeated4x4transform materializationRelCartesianOSCActionto use the optimized Jacobian path directlyWhy this matters:
RelCartesianOSCAction.apply_actions()sits on the physics-step path for OmniReset UR5e tasksnum_envsVerification:
python3 -m compileall source/uwlab_assets/uwlab_assets/robots/ur5e_robotiq_gripper/kinematics.py source/uwlab_tasks/uwlab_tasks/manager_based/manipulation/omnireset/mdp/actions/task_space_actions.py source/uwlab_assets/test/test_ur5e_kinematics.pygit diff --checktorchandisaaclabare not installed locallyFixes N/A
Type of change
Screenshots
Not applicable.
Checklist
pre-commitchecks with./uwlab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there