Fix GeoAxes grid label formatting through SubplotGrid and Figure format dispatch#724
Merged
Merged
Conversation
…options like labelsize worked when formatting a single GeoAxes directly, but were silently ignored when the same axes was formatted through SubplotGrid.format() or Figure.format(). The higher-level formatting paths were treating names like labelsize as rc-style aliases and removing them before dispatching to the projection-specific GeoAxes.format() method. The underlying behavior goes back to the ProPlot inheritance chain. GeoAxes.format(labelsize=..., labelweight=...) was introduced there in October 2021, while the figure-level formatting dispatch was already using _pop_rc(kwargs). That meant the collision between explicit geo formatting keywords and rc aliases had been latent for a long time. This change preserves explicit projection-specific formatting arguments during figure and subplot-grid dispatch so that geographic label styling behaves the same whether users call ax.format(...) or axs.format(...).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gepcel
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #723
This fixes a long-standing issue where geographic grid label styling options like labelsize worked when formatting a single GeoAxes directly, but were silently ignored when the same axes was formatted through SubplotGrid.format() or Figure.format(). The higher-level formatting paths were treating names like labelsize as rc-style aliases and removing them before dispatching to the projection-specific GeoAxes.format() method.
The underlying behavior goes back to the ProPlot inheritance chain. GeoAxes.format(labelsize=..., labelweight=...) was introduced there in October 2021, while the figure-level formatting dispatch was already using _pop_rc(kwargs). That meant the collision between explicit geo formatting keywords and rc aliases had been latent for a long time. This change preserves explicit projection-specific formatting arguments during figure and subplot-grid dispatch so that geographic label styling behaves the same whether users call ax.format(...) or axs.format(...).