Skip to content

[pull] master from leonardomso:master #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
May 12, 2026
+1 −4
Merged

[pull] master from leonardomso:master #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cf23d4
refactor: wrap callback-based image loader with Promise API
0mega28 Apr 18, 2026
6eae5b2
Merge pull request #657 from 0mega28/refactor/promise-wrapper-load-image
leonardomso May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions docs/concepts/promises.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,10 +412,7 @@ function loadImageCallback(url, onSuccess, onError) {
// Promise-based wrapper
function loadImage(url) {
return new Promise((resolve, reject) => {
const img = new Image()
img.onload = () => resolve(img)
img.onerror = () => reject(new Error(`Failed to load ${url}`))
img.src = url
loadImageCallback(url, resolve, reject);
})
}

Expand Down