[pull] master from monkeytypegame:master#872
Merged
Merged
Conversation
…ydwivedi) (#7837) ## Summary - **Efficient friends leaderboard count**: Replaced full document fetch + `.length` with a `$count` aggregation stage in `getCount()` for the friends-only path. - **Atomic PB update**: Merged two separate `updateOne` calls in `checkIfPb()` into a single update, so `personalBests` and optional `lbPersonalBests` are written together. - **Remove debug console.log**: Removed the `console.log` in `addImportantLog()` that printed event name, payload, and UID. ## Files Changed | File | Change | |------|--------| | `backend/src/dal/leaderboards.ts` | Friends count now uses `$count` aggregation | | `backend/src/dal/user.ts` | Atomic PB update (streak migration guard retained) | | `backend/src/dal/logs.ts` | Remove debug `console.log` | ## Test Plan - [x] Verify friends leaderboard count returns correct values with `$count` - [x] Verify PB updates persist both `personalBests` and `lbPersonalBests` in one update - [x] Run existing test suite (`pnpm test-be`) ## Notes - Tests were not run in this local environment because the repo requires Node `>=24 <25` and the current environment is Node `v20.16.0`. Co-authored-by: Jack <jack@monkeytype.com>
…er on input (@AzureNightlock) (#7851) ### Description This PR: Fixes the first character being skipped on input by only clearing the form when the page isn't open. Changes Made: * form.reset() runs only when isOpen is false, Hence clearing the form when the user leaves the page. When the user comes back to the page, the form is cleared instead of clearing when the user first enters the page Additional Changes Made: * Removed the unused catch parameter ("e") from onChangeAsync. * showIndicator doesn't show up when the field is blank ### Checks - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. Closes #7850 Co-authored-by: Christian Fehmer <fehmer@users.noreply.github.com>
…7849) ### Current Behavior for Reduced Motion 1. keep - Letters stay (No change) 2. hide - Letters vanish instantly (No change) 3. fade - Letters stay **(Effect is lost)** 4. dots - Letters become dots instantly (has a Fallback) ### Changes This PR makes sure that `fade` effect works for reduced motion by adding it to the global exclude list for reduced motion. Closes #7847
<img width="755" height="762" alt="image" src="https://github.com/user-attachments/assets/c5164819-c157-4a71-b415-ff58bda27735" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )