fix: h264 level selection algorithm

[RebootVanChild]

There seems to be a slight issue in the h264 level selection algorithm. Widths and heights of frames and h264 macroblocks should be taken into account when doing the calculation, not only the pixel counts.
This issue can cause encoder invalid param error on certain resolution ranges.

For example, a 1922x1080 30fps video stream:

The correct algorithm should be

macroblocksPerFrame = Ceil( pixelsFrameWidth / pixelsMacroblockSide ) * Ceil( pixelsFrameHeight / pixelsMacroblockSide )
= Ceil( 1922 / 16 ) * Ceil( 1080 / 16 )
= 8228

Which resides in level 4.2.

However, according to current algorithm

macroblocksPerFrame = Ceil( pixelsPerFrame / pixelsPerMacroblock )
= Ceil( 1922 * 1080 / (16 * 16) )
= 8109

Thus, the algorithm would select level 4, and cause encoder invalid param error.

[doctorpangloss]

is this related?

#896

Really the minimum level should always be h264 42

[Copilot]

Pull Request Overview

This PR fixes the H.264 level selection algorithm to correctly calculate macroblocks per frame by considering width and height dimensions separately rather than total pixel count. This addresses encoder parameter errors that occur with certain resolutions like 1922x1080.

• Updates the macroblock calculation to use ceiling division of width and height by macroblock side length (16 pixels)
• Changes function signatures to accept separate width and height parameters instead of pixel count
• Updates all test cases and function calls to use the new signature

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
H264ProfileLevelId.cpp	Implements the corrected macroblock calculation algorithm using separate width/height parameters
H264ProfileLevelId.h	Updates function signatures to accept width and height separately
NvEncoderImpl.cpp	Updates function calls to pass separate width and height values
H264ProfileLevelIdTest.cpp	Updates test cases to use new function signature with separate width/height parameters

[Copilot]

There is a spelling error in the comment: 'calclated' should be 'calculated'.

Suggested change

	// Returns the max framerate that calclated by maxFrameWidthPixelCount and maxFrameHeightPixelCount.
	// Returns the max framerate that calculated by maxFrameWidthPixelCount and maxFrameHeightPixelCount.