Open
Conversation
There was a problem hiding this comment.
1 issue found across 23 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name=".github/workflows/e2e.yml">
<violation number="1" location=".github/workflows/e2e.yml:187">
P2: Use the content-hashed image tag from `build-base` instead of the mutable `latest` tag so the E2E job uses the exact base image built in this workflow run.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache the E2E test base Docker image in GitHub Container Registry (GHCR) to reduce redundant builds across matrix jobs and improve CI reproducibility.
Changes
build-basejob that builds and pushes the base image to GHCR with BuildKit layer cachingBASE_IMAGEas a build arg with local fallback defaultBASE_IMAGEfrom environmentpackages: writepermission for GHCR pushNotes
python-e2e-base:latestwhich can be built locallyNo significant gains (e2e tests still take ~1 min each), not worth the effort and cache maintenance, shelving for now.