Skip to content

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Dec 29, 2025

Add zizmor to dev dependencies and pre-commit config for GitHub Actions workflow security linting.

Changes

  • Add zizmor==1.19.0 to dev dependencies in pyproject.toml
  • Add zizmor pre-commit hook (runs on YAML files in .github directory)
  • Add zizmor to ci.skip list (where applicable)

Note

Introduces GitHub Actions security linting with zizmor and hardens workflow permissions.

  • Adds zizmor==1.19.0 to dev dependencies and a zizmor pre-commit hook (targets .github YAML); added to ci.skip
  • Adds zizmor.yml configuration disabling selected rules
  • Hardens workflows: sets permissions: {} in CI and uses actions/checkout with persist-credentials: false in CI and Release

Written by Cursor Bugbot for commit c06b487. This will update automatically on new commits. Configure here.

@adamtheturtle adamtheturtle merged commit ee94a0f into main Dec 29, 2025
9 checks passed
@adamtheturtle adamtheturtle deleted the add-zizmor branch December 29, 2025 17:04
steps:
- uses: actions/checkout@v6
with:
persist-credentials: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting persist-credentials false breaks git auto commit action

Adding persist-credentials: false to the checkout step will break the release workflow. The stefanzweifel/git-auto-commit-action@v7 used later (line 74) relies on git credentials being persisted in the local git config to push commits. When persist-credentials: false is set, the PAT token from the checkout step is not stored in git config, so the auto-commit action cannot authenticate and the push will fail. This is a documented incompatibility (git-auto-commit-action Discussion #356).

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants