steampipe_fixups: skip missing no_write_paths entries#9834
Open
danyalahmed1995 wants to merge 1 commit into
Open
steampipe_fixups: skip missing no_write_paths entries#9834danyalahmed1995 wants to merge 1 commit into
danyalahmed1995 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
steampipe_fixups.do_restore()currently assumes everyno_write_pathsentry fromsteampipe_fixups.jsonstill exists. If one of those files is missing, restore fails withFileNotFoundErrorbefore Proton can launch.This skips missing
no_write_pathsentries during restore, while still applying the chmod behavior to files that do exist.For #9746.
Testing
FileNotFoundErrorwith a minimal manifest containing a missingno_write_pathsentry.no_write_pathsentries still have write bits removed.empty_dirsbehavior is unchanged.python -m py_compile steampipe_fixups.py.