Skip to content

proton: detect incomplete default_pfx#9837

Open
danyalahmed1995 wants to merge 1 commit into
ValveSoftware:proton_11.0from
danyalahmed1995:investigate-default-pfx-9660
Open

proton: detect incomplete default_pfx#9837
danyalahmed1995 wants to merge 1 commit into
ValveSoftware:proton_11.0from
danyalahmed1995:investigate-default-pfx-9660

Conversation

@danyalahmed1995
Copy link
Copy Markdown

Summary

missing_default_prefix() only checked whether the default_pfx directory exists. If the directory exists but is empty or incomplete, Proton treats it as valid and skips rebuilding it with wineboot.

This updates the check to require a few expected default prefix files that later setup code depends on:

  • system.reg
  • drive_c/windows/system32/d3d8.dll
  • drive_c/windows/syswow64/d3d8.dll

For #9660.

Testing

  • Reproduced the validation failure with an empty/incomplete default_pfx directory.
  • Verified an absent default_pfx is still treated as missing.
  • Verified an empty default_pfx is now treated as missing.
  • Verified a partially-created default_pfx without the expected sentinel files is treated as missing.
  • Verified a sentinel-valid default_pfx is treated as present.
  • Ran python -m py_compile proton steampipe_fixups.py.
  • Ran git diff --check.

@danyalahmed1995 danyalahmed1995 force-pushed the investigate-default-pfx-9660 branch from e50de29 to 1dd3f1c Compare May 30, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant