proton: detect incomplete default_pfx#9837
Open
danyalahmed1995 wants to merge 1 commit into
Open
Conversation
e50de29 to
1dd3f1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
missing_default_prefix()only checked whether thedefault_pfxdirectory exists. If the directory exists but is empty or incomplete, Proton treats it as valid and skips rebuilding it withwineboot.This updates the check to require a few expected default prefix files that later setup code depends on:
system.regdrive_c/windows/system32/d3d8.dlldrive_c/windows/syswow64/d3d8.dllFor #9660.
Testing
default_pfxdirectory.default_pfxis still treated as missing.default_pfxis now treated as missing.default_pfxwithout the expected sentinel files is treated as missing.default_pfxis treated as present.python -m py_compile proton steampipe_fixups.py.git diff --check.