steamcompmgr: remove duplicated cursor warp from keyboard focus block#2201
Open
matte-schwartz wants to merge 1 commit into
Open
steamcompmgr: remove duplicated cursor warp from keyboard focus block#2201matte-schwartz wants to merge 1 commit into
matte-schwartz wants to merge 1 commit into
Conversation
93cf2b4 split focus handling into separate keyboard and mouse blocks, but added a second copy of the bResetToCorner/Center warp to the new keyboard block. The keyboard block runs before pointer focus is handed to the new window via wlserver_mousefocus, so on handhelds the warp is delivered to the still-focused game and can warp the camera when opening the QAM. Keep the warp only in the mouse focus block, where it runs after the pointer handoff. Closes: ValveSoftware/SteamOS#2441
Author
|
@misyltoad i don't have any VR hardware to confirm this doesn't regress what you were trying to fix in the VR backend, but I'm pretty sure it shouldn't |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
93cf2b4 split focus handling into separate keyboard and mouse blocks, but added a second copy of the bResetToCorner/Center warp to the new keyboard block. The keyboard block runs before pointer focus is handed to the new window via wlserver_mousefocus, so on handhelds the warp is delivered to the still-focused game and can warp the camera when opening the QAM.
Keep the warp only in the mouse focus block, where it runs after the pointer handoff.
Closes: ValveSoftware/SteamOS#2441