Stop splash damage from being able to go through walls#1940
Open
Goennigoegoe wants to merge 3 commits into
Open
Stop splash damage from being able to go through walls#1940Goennigoegoe wants to merge 3 commits into
Goennigoegoe wants to merge 3 commits into
Conversation
|
I don't exactly feel like a PR related to fixing splash dmg through walls should include edits to .gitignore or add in a tf specific build script |
Author
|
Oh sorry, it was probably due to my visual studio stuff, I will try removing them. |
Author
|
I have reverted them, it still has extra commits for it but eh, it doesn't add / change the files anymore. |
Author
|
Here's the test position since I forgot to add it into the description: setpos 749.287903 1829.719727 -187.167358;setang -23.551832 11.992801 0.000000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug that lets splash damage go through walls in certain cases.
The bug is caused due to plane normal being added to explosion pos and explosion damage not being checked correctly for starting in a solid.
It has 2 fixes, one that adds the check for starting in a solid and another that removes the plane normal addition.
They are togglable via the ConVars: "tf_splash_fix" and "tf_splash_fix_extreme".
The extreme version might cause issues with splash damage being eaten by things it shouldn't be. It does fix a bug where you are able to shoot around corners if aiming close enough to the corner.
The normal version doesn't cause issues as far as I've tested.
Showcase: https://www.youtube.com/watch?v=OJ7SZjltdbw